Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS simulator device to use the one that's available #1592

Merged
merged 3 commits into from
May 14, 2024

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented May 13, 2024

Runners only have 17.4 on the the 10th-gen iPad by default.

Description

Provide details of the change, and generalize the change in the PR title above.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label May 13, 2024
@jonsimantov jonsimantov changed the title Fix iOS simulator device to use the one that's preinstalled on the ru… Fix iOS simulator device to use the one that's available May 13, 2024
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label May 13, 2024
Copy link

github-actions bot commented May 13, 2024

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit 62eac55
Last updated: Tue May 14 13:24 PDT 2024
View integration test log & download artifacts

Failures Configs
gma [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  FirebaseGmaTest.TestAdView

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 13, 2024
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels May 13, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 13, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: failed This PR's integration tests failed. labels May 14, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 14, 2024
@jonsimantov jonsimantov requested a review from a-maurice May 14, 2024 17:07
@jonsimantov jonsimantov merged commit 62eac55 into main May 14, 2024
48 of 49 checks passed
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels May 14, 2024
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 14, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 14, 2024
@firebase firebase locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants