-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make UpdateUserProfile consistent on clearing fields on Android #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-maurice
added
the
tests-requested: quick
Trigger a quick set of integration tests.
label
Oct 3, 2024
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
and removed
tests-requested: quick
Trigger a quick set of integration tests.
labels
Oct 3, 2024
Integration test with FLAKINESS (succeeded after retry)Requested by @a-maurice on commit d8ffa49
Add flaky tests to go/fpl-cpp-flake-tracker |
github-actions
bot
added
the
tests: succeeded
This PR's integration tests succeeded.
label
Oct 3, 2024
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Oct 3, 2024
jonsimantov
approved these changes
Oct 7, 2024
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
and removed
tests: succeeded
This PR's integration tests succeeded.
labels
Oct 8, 2024
github-actions
bot
added
the
tests: succeeded
This PR's integration tests succeeded.
label
Oct 9, 2024
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Oct 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On iOS and Desktop, setting photo_url to nullptr resulted in no change to the user, and empty string resulted in clearing the field on user. On Android, both resulted in no change in the user. Make it consistently clear the field with an empty string, and do no change with nullptr. And added tests to verify.
Testing
Type of Change
Place an
x
the applicable box:Notes
Release Notes
section ofrelease_build_files/readme.md
.