Skip to content

Remove deprecated cpp auth function #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 14, 2025

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

google-labs-jules bot and others added 6 commits July 2, 2025 23:46
Matching a change made in the Unity SDK, this commit removes:
- Auth: `User::UpdateEmail` and `User::UpdateEmailLastResult`

Updated the release notes to reflect this change.
Matching a change made in the Unity SDK, this commit removes:
- Auth: `User::UpdateEmail` and `User::UpdateEmailLastResult` methods.

Integration tests in `ta/auth/it/src/integration_test.cc` were updated:
- Removed a call to `UpdateEmail` on an invalid user.
- Commented out calls to `UpdateEmail` in `TestUpdateEmailAndPassword` to allow build to pass. Further work is needed to update this test to the new email verification flow.

Updated the release notes to reflect this change.
Matching a change made in the Unity SDK, this commit removes:
- Auth: `User::UpdateEmail` and `User::UpdateEmailLastResult` methods.

Integration tests in `ta/auth/it/src/integration_test.cc` were updated:
- Removed a call to `UpdateEmail` on an invalid user.
- Removed commented-out calls to `UpdateEmail` in `TestUpdateEmailAndPassword`.

Updated the release notes to reflect this change.
… all tests.

To match a change made in the Unity SDK, I will remove:
- Auth: `User::UpdateEmail` and `User::UpdateEmailLastResult` methods.

I will also remove all usages of the deprecated method from the
integration tests (`auth/integration_test/src/integration_test.cc`) and
unit tests (`auth/tests/user_test.cc` and
`auth/tests/desktop/user_desktop_test.cc`).

I will then update the release notes to reflect this change.
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jul 14, 2025
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 14, 2025
Copy link

github-actions bot commented Jul 14, 2025

❌  Integration test FAILED

Requested by @jonsimantov on commit 664b2a2
Last updated: Mon Jul 14 15:22 PDT 2025
View integration test log & download artifacts

Failures Configs
auth [TEST] [FAILURE] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  FirebaseAuthTest.TestSignInWithBadEmailFails
[TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  FirebaseAuthTest.TestSignInWithBadEmailFails
[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  FirebaseAuthTest.TestSignInWithBadEmailFails

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jul 14, 2025
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 14, 2025
@jonsimantov jonsimantov requested a review from a-maurice July 14, 2025 19:57
@jonsimantov jonsimantov changed the title Remove deprecated cpp auth function 2 Remove deprecated cpp auth function Jul 14, 2025
@jonsimantov jonsimantov marked this pull request as ready for review July 14, 2025 20:02
@jonsimantov jonsimantov enabled auto-merge (squash) July 14, 2025 20:03
@jonsimantov jonsimantov disabled auto-merge July 14, 2025 20:03
@jonsimantov jonsimantov enabled auto-merge (squash) July 14, 2025 20:03
@jonsimantov jonsimantov merged commit 664b2a2 into main Jul 14, 2025
29 checks passed
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Jul 14, 2025
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants