-
Notifications
You must be signed in to change notification settings - Fork 124
Remove deprecated cpp auth function #1772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matching a change made in the Unity SDK, this commit removes: - Auth: `User::UpdateEmail` and `User::UpdateEmailLastResult` Updated the release notes to reflect this change.
Matching a change made in the Unity SDK, this commit removes: - Auth: `User::UpdateEmail` and `User::UpdateEmailLastResult` methods. Integration tests in `ta/auth/it/src/integration_test.cc` were updated: - Removed a call to `UpdateEmail` on an invalid user. - Commented out calls to `UpdateEmail` in `TestUpdateEmailAndPassword` to allow build to pass. Further work is needed to update this test to the new email verification flow. Updated the release notes to reflect this change.
Matching a change made in the Unity SDK, this commit removes: - Auth: `User::UpdateEmail` and `User::UpdateEmailLastResult` methods. Integration tests in `ta/auth/it/src/integration_test.cc` were updated: - Removed a call to `UpdateEmail` on an invalid user. - Removed commented-out calls to `UpdateEmail` in `TestUpdateEmailAndPassword`. Updated the release notes to reflect this change.
… all tests. To match a change made in the Unity SDK, I will remove: - Auth: `User::UpdateEmail` and `User::UpdateEmailLastResult` methods. I will also remove all usages of the deprecated method from the integration tests (`auth/integration_test/src/integration_test.cc`) and unit tests (`auth/tests/user_test.cc` and `auth/tests/desktop/user_desktop_test.cc`). I will then update the release notes to reflect this change.
❌ Integration test FAILEDRequested by @jonsimantov on commit 664b2a2
Add flaky tests to go/fpl-cpp-flake-tracker |
a-maurice
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
Type of Change
Place an
x
the applicable box:Notes
Release Notes
section ofrelease_build_files/readme.md
.