Use nullish coalescing instea of logical or.

firebase · Aug 23, 2024 · df1f362 · df1f362
1 parent d30cdfb
commit df1f362
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 8 deletions.
diff --git a/src/v2/providers/alerts/alerts.ts b/src/v2/providers/alerts/alerts.ts
@@ -250,7 +250,7 @@ export function getEndpointAnnotation(
       eventFilters: {
         alerttype: alertType,
       },
-      retry: opts.retry || false,
+      retry: opts.retry ?? false,
     },
   };
   if (appId) {

diff --git a/src/v2/providers/database.ts b/src/v2/providers/database.ts
@@ -447,7 +447,7 @@ export function makeEndpoint(
       eventType,
       eventFilters,
       eventFilterPathPatterns,
-      retry: opts.retry || false,
+      retry: opts.retry ?? false,
     },
   };
 }

diff --git a/src/v2/providers/eventarc.ts b/src/v2/providers/eventarc.ts
@@ -217,7 +217,7 @@ export function onCustomEventPublished<T = any>(
     eventTrigger: {
       eventType: opts.eventType,
       eventFilters: {},
-      retry: opts.retry || false,
+      retry: opts.retry ?? false,
       channel,
     },
   };

diff --git a/src/v2/providers/firestore.ts b/src/v2/providers/firestore.ts
@@ -685,7 +685,7 @@ export function makeEndpoint(
       eventType,
       eventFilters,
       eventFilterPathPatterns,
-      retry: opts.retry || false,
+      retry: opts.retry ?? false,
     },
   };
 }

diff --git a/src/v2/providers/pubsub.ts b/src/v2/providers/pubsub.ts
@@ -345,7 +345,7 @@ export function onMessagePublished<T = any>(
     eventTrigger: {
       eventType: "google.cloud.pubsub.topic.v1.messagePublished",
       eventFilters: { topic },
-      retry: opts.retry || false,
+      retry: opts.retry ?? false,
     },
   };
   copyIfPresent(endpoint.eventTrigger, opts, "retry", "retry");

diff --git a/src/v2/providers/remoteConfig.ts b/src/v2/providers/remoteConfig.ts
@@ -149,7 +149,7 @@ export function onConfigUpdated(
     eventTrigger: {
       eventType,
       eventFilters: {},
-      retry: optsOrHandler.retry || false,
+      retry: optsOrHandler.retry ?? false,
     },
   };
   func.__endpoint = ep;

diff --git a/src/v2/providers/storage.ts b/src/v2/providers/storage.ts
@@ -624,7 +624,7 @@ export function onOperation(
         eventTrigger: {
           eventType,
           eventFilters: { bucket },
-          retry: opts.retry || false,
+          retry: opts.retry ?? false,
         },
       };
       copyIfPresent(endpoint.eventTrigger, opts, "retry", "retry");

diff --git a/src/v2/providers/testLab.ts b/src/v2/providers/testLab.ts
@@ -207,7 +207,7 @@ export function onTestMatrixCompleted(
     eventTrigger: {
       eventType,
       eventFilters: {},
-      retry: optsOrHandler.retry || false,
+      retry: optsOrHandler.retry ?? false,
     },
   };
   func.__endpoint = ep;