Skip to content

Commit

Permalink
Fix typo: Timout -> Timeout (#12672)
Browse files Browse the repository at this point in the history
  • Loading branch information
Jager-yoo authored Apr 1, 2024
1 parent 1af0bf0 commit 02d2b29
Show file tree
Hide file tree
Showing 4 changed files with 31 additions and 31 deletions.
12 changes: 6 additions & 6 deletions FirebaseDynamicLinks/Tests/Unit/FIRDLScionLoggingTest.m
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
#import <OCMock/OCMock.h>
#import "FirebaseDynamicLinks/Sources/FIRDLScionLogging.h"

static const NSTimeInterval kAsyncTestTimout = 0.5;
static const NSTimeInterval kAsyncTestTimeout = 0.5;

typedef void (^FakeAnalyticsLogEventWithOriginNameParametersHandler)(NSString *origin,
NSString *name,
Expand Down Expand Up @@ -113,7 +113,7 @@ - (void)testGINLogEventToScionCallsLogMethodWithFirstOpen {
}];

FIRDLLogEventToScion(FIRDLLogEventFirstOpen, nil, nil, nil, analytics);
[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];
}

- (void)testGINLogEventToScionContainsCorrectNameWithFirstOpen {
Expand All @@ -126,7 +126,7 @@ - (void)testGINLogEventToScionContainsCorrectNameWithFirstOpen {
}];

FIRDLLogEventToScion(FIRDLLogEventFirstOpen, nil, nil, nil, analytics);
[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];
}

- (void)testGINLogEventToScionCallsLogMethodWithAppOpen {
Expand All @@ -138,7 +138,7 @@ - (void)testGINLogEventToScionCallsLogMethodWithAppOpen {
}];
FIRDLLogEventToScion(FIRDLLogEventAppOpen, nil, nil, nil, analytics);

[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];
}

- (void)testGINLogEventToScionContainsCorrectNameWithAppOpen {
Expand All @@ -151,7 +151,7 @@ - (void)testGINLogEventToScionContainsCorrectNameWithAppOpen {
}];
FIRDLLogEventToScion(FIRDLLogEventAppOpen, nil, nil, nil, analytics);

[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];
}

- (void)testGINLogEventToScionLogsParametersCorrectly {
Expand All @@ -176,7 +176,7 @@ - (void)testGINLogEventToScionLogsParametersCorrectly {

FIRDLLogEventToScion(FIRDLLogEventAppOpen, source, medium, campaign, analytics);

[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];
}

@end
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
static NSString *const kAPIKey = @"myfakeapikey";
const NSInteger kJSONParsingErrorCode = 3840;
static NSString *const kURLScheme = @"gindeeplinkurl";
static const NSTimeInterval kAsyncTestTimout = 5.0;
static const NSTimeInterval kAsyncTestTimeout = 5.0;

@interface FIRDynamicLinkNetworkingTests : XCTestCase

Expand Down Expand Up @@ -90,7 +90,7 @@ - (void)testResolveShortLinkServiceCompletionDoesntCrashWhenNilDataIsRetrieved {
[expectation fulfill];
}];

[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];

[GULSwizzler unswizzleClass:[FIRDynamicLinkNetworking class]
selector:executeRequestSelector
Expand Down
38 changes: 19 additions & 19 deletions FirebaseDynamicLinks/Tests/Unit/FIRDynamicLinksTest.m
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
@"https://sample.page.link?link=%@&isi=585027354";
static NSString *const kURLScheme = @"gindeeplinkurl";

static const NSTimeInterval kAsyncTestTimout = 5.0;
static const NSTimeInterval kAsyncTestTimeout = 5.0;

/**
* This string was generated by percent-encoding the Tactile URL for the Tokyo American Club in
Expand Down Expand Up @@ -526,7 +526,7 @@ - (void)testDynamicLinkFromUniversalLinkURLCompletionWithCustomDomainLink {
@"ddl url parameter and deep link url should be the same");
[expectation fulfill];
}];
[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];

UnswizzleDynamicLinkNetworking();
}
Expand Down Expand Up @@ -567,7 +567,7 @@ - (void)testDynamicLinkFromUniversalLinkURLCompletionWithSpecialCharacters {
@"ddl url parameter and deep link url should be the same");
[expectation fulfill];
}];
[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];

UnswizzleDynamicLinkNetworking();
}
Expand Down Expand Up @@ -608,7 +608,7 @@ - (void)testDynamicLinkFromUniversalLinkURLCompletionWithEncodedCharacters {
@"ddl url parameter and deep link url should be the same");
[expectation fulfill];
}];
[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];

UnswizzleDynamicLinkNetworking();
}
Expand Down Expand Up @@ -657,7 +657,7 @@ - (void)testUniversalLinkWithCompletion_DeepLink {
XCTAssertEqualObjects(dynamicLink.url.absoluteString, deepLinkString);
[expectation fulfill];
}];
[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];

UnswizzleDynamicLinkNetworking();
}
Expand Down Expand Up @@ -707,7 +707,7 @@ - (void)testUniversalLinkWithCompletion_DeepLinkWithParameters {
parsedDeepLinkString);
[expectation fulfill];
}];
[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];
UnswizzleDynamicLinkNetworking();
}

Expand Down Expand Up @@ -745,7 +745,7 @@ - (void)testResolveLinkReturnsDLWithNilMinAppVersionWhenNotPresent {
[expectation fulfill];
}];

[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];
}

- (void)testResolveLinkReturnsDLWithMinAppVersionWhenPresent {
Expand Down Expand Up @@ -790,7 +790,7 @@ - (void)testResolveLinkReturnsDLWithMinAppVersionWhenPresent {
[expectation fulfill];
}];

[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];
}

- (void)testUniversalLinkWithSubdomain_NoDeepLink {
Expand Down Expand Up @@ -871,7 +871,7 @@ - (void)testDynamicLinkFromUniversalLinkURLCompletionReturnsDLWithNilMinimumVers
XCTAssertNil(minVersion, @"Min app version was not nil when not set.");
[expectation fulfill];
}];
[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];
}

- (void)testDynamicLinkFromUniversalLinkURLReturnsDLMinimumVersion {
Expand Down Expand Up @@ -948,7 +948,7 @@ - (void)testDynamicLinkFromUniversalLinkURLReturnsUTMParams {
[expectation fulfill];
}];

[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];
}

- (void)testDynamicLinkFromUniversalLinkURLCompletionReturnsDLMinimumVersion {
Expand Down Expand Up @@ -976,7 +976,7 @@ - (void)testDynamicLinkFromUniversalLinkURLCompletionReturnsDLMinimumVersion {
@"Min version didn't match imv= parameter");
[expectation fulfill];
}];
[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];
}

- (void)testUniversalLinkWithSubdomain_DeepLink {
Expand Down Expand Up @@ -1022,7 +1022,7 @@ - (void)testUniversalLinkWithCompletionWithSubdomain_DeepLink {
XCTAssertEqualObjects(dynamicLink.url.absoluteString, deepLinkString);
[expectation fulfill];
}];
[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];

UnswizzleDynamicLinkNetworking();
}
Expand Down Expand Up @@ -1067,7 +1067,7 @@ - (void)testUniversalLinkWithCompletionWithSubdomain_DeepLinkWithParameters {
parsedDeepLinkString);
[expectation fulfill];
}];
[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];
}

- (void)testResolveLinkRespectsResponseSuccessStatusCode {
Expand Down Expand Up @@ -1105,7 +1105,7 @@ - (void)testResolveLinkRespectsResponseSuccessStatusCode {
[expectation fulfill];
}];

[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];
}

- (void)testResolveLinkRespectsResponseErrorStatusCode {
Expand Down Expand Up @@ -1152,7 +1152,7 @@ - (void)testResolveLinkRespectsResponseErrorStatusCode {
[expectation fulfill];
}];

[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];
}

- (void)testPassMatchesShortLinkFormatForDDLDomains {
Expand Down Expand Up @@ -1354,7 +1354,7 @@ - (void)testHandleUniversalLinkWithShortLink {
[handleLinkCompletionExpectation fulfill];
}];

[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];
UnswizzleDynamicLinkNetworking();
}

Expand Down Expand Up @@ -1386,7 +1386,7 @@ - (void)testHandleUniversalLinkWithLongLink {
[self.service handleUniversalLink:[NSURL URLWithString:longLinkString]
completion:handleUniversalLinkBlock];

[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];

// It is expected to call resolveLink once for logging.
XCTAssertEqual(resolverInvocationsCount, 1,
Expand Down Expand Up @@ -1415,7 +1415,7 @@ - (void)testHandleUniversalLinkCallsHandleUniversalLinkResolver {
completion:^(FIRDynamicLink *_Nullable dynamicLink, NSError *_Nullable error){
}];

[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];

[GULSwizzler unswizzleClass:[FIRDynamicLinks class]
selector:selectorToSwizzle
Expand Down Expand Up @@ -1491,7 +1491,7 @@ - (void)testHandleUniversalLinkCompletionReturnsYesForValidDDL {

XCTAssertTrue(handled, @"Valid DDL Universal Link was not handled");

[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];
}
}

Expand Down
8 changes: 4 additions & 4 deletions FirebaseMessaging/Tests/UnitTests/FIRMessagingAnalyticsTest.m
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
static NSString *const kReengagementSource = @"Firebase";
static NSString *const kReengagementMedium = @"notification";
static NSString *const kFIREventOriginFCM = @"fcm";
static const NSTimeInterval kAsyncTestTimout = 0.5;
static const NSTimeInterval kAsyncTestTimeout = 0.5;

typedef void (^FakeAnalyticsLogEventHandler)(NSString *origin,
NSString *name,
Expand Down Expand Up @@ -237,7 +237,7 @@ - (void)testNoParamsIfEmpty {
[FIRMessagingAnalytics logEvent:kFIRIEventFirebaseCampaign
withNotification:notification
toAnalytics:analytics];
[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];
}
- (void)testParamForEventAndNotification {
NSDictionary *notification = @{
Expand Down Expand Up @@ -373,7 +373,7 @@ - (void)testConversionTracking {
expectation = nil;
}];
[FIRMessagingAnalytics logUserPropertyForConversionTracking:notification toAnalytics:analytics];
[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];
}

- (void)testConversionTrackingUserProperty {
Expand Down Expand Up @@ -401,7 +401,7 @@ - (void)testConversionTrackingUserProperty {
[expectation fulfill];
}];
[FIRMessagingAnalytics logUserPropertyForConversionTracking:notification toAnalytics:analytics];
[self waitForExpectationsWithTimeout:kAsyncTestTimout handler:nil];
[self waitForExpectationsWithTimeout:kAsyncTestTimeout handler:nil];
}

- (void)testNoConversionTracking {
Expand Down

0 comments on commit 02d2b29

Please sign in to comment.