fix the sign in with deleted passkey crash issue (#12710)

FirebaseAuth/Sources/Auth/FIRAuth.m

@@ -1281,6 +1281,7 @@ - (void)finalizePasskeySignInWithPlatformCredential:
                                 NSError *_Nullable error) {
                        if (error) {
                          decoratedCallback(nil, error);
+                         return;
                        }
                        [self completeSignInWithAccessToken:response.idToken
                                  accessTokenExpirationDate:nil

FirebaseAuth/Sources/Backend/FIRAuthBackend.m

@@ -561,10 +561,16 @@
 
 /** @var kInvalidLoginCredentials
     @brief This is the error message the server will respond with if the login credentials is
-   invalid. in the request.
+   invalid in the request.
  */
 static NSString *const kInvalidLoginCredentials = @"INVALID_LOGIN_CREDENTIALS";
 
+/** @var kPasskeyEnrollmentNotFound
+    @brief This is the error message the server will respond with if the passkey credentials is
+   invalid in the request.
+ */
+static NSString *const kPasskeyEnrollmentNotFound = @"PASSKEY_ENROLLMENT_NOT_FOUND";
+
 /** @var gBackendImplementation
     @brief The singleton FIRAuthBackendImplementation instance to use.
  */
@@ -1400,7 +1406,6 @@ - (void)callWithRequest:(id<FIRAuthRPCRequest>)request
                                                                    underlyingError:error]);
                                return;
                              }
-
                              // Finally, we try to populate the response object with the JSON
                              // values.
                              if (![response setWithDictionary:dictionary error:&error]) {
@@ -1475,6 +1480,10 @@ + (nullable NSError *)clientErrorWithServerErrorMessage:(NSString *)serverErrorM
     return [FIRAuthErrorUtils userNotFoundErrorWithMessage:serverDetailErrorMessage];
   }
 
+  if ([shortErrorMessage isEqualToString:kPasskeyEnrollmentNotFound]) {
+    return [FIRAuthErrorUtils passkeyEnrollmentNotFoundError];
+  }
+
   if ([shortErrorMessage isEqualToString:kUserDeletedErrorMessage]) {
     return [FIRAuthErrorUtils userNotFoundErrorWithMessage:serverDetailErrorMessage];
   }

FirebaseAuth/Sources/Public/FirebaseAuth/FIRAuthErrors.h

@@ -458,6 +458,10 @@ typedef NS_ERROR_ENUM(FIRAuthErrorDomain, FIRAuthErrorCode){
      */
     FIRAuthErrorCodeRecaptchaSDKNotLinked = 17208,
 
+    /** Indicates the user account was not found.
+     */
+    FIRAuthErrorCodePasskeyEnrollmentNotFound = 17209,
+
     /** Indicates an error occurred while attempting to access the keychain.
      */
     FIRAuthErrorCodeKeychainError = 17995,

FirebaseAuth/Sources/User/FIRUser.m

@@ -673,6 +673,7 @@ - (void)finalizePasskeyEnrollmentWithPlatformCredential:
                                     NSError *_Nullable error) {
                            if (error) {
                              decoratedCallback(nil, error);
+                             return;
                            } else {
                              [FIRAuth.auth
                                  completeSignInWithAccessToken:response.idToken

FirebaseAuth/Sources/Utilities/FIRAuthErrorUtils.h

@@ -489,6 +489,12 @@ static NSString *const kMissingRecaptchaTokenErrorPrefix = @"MISSING_RECAPTCHA_T
  */
 + (NSError *)notificationNotForwardedError;
 
+/** @fn passkeyEnrollmentNotFoundError
+    @brief Constructs an @c NSError with the @c FIRAuthErrorCodeNotificationNotForwarded code.
+    @return The NSError instance associated with the given FIRAuthError.
+ */
++ (NSError *)passkeyEnrollmentNotFoundError;
+
 #if TARGET_OS_IOS
 /** @fn secondFactorRequiredError
     @brief Constructs an @c NSError with the @c FIRAuthErrorCodeSecondFactorRequired code.

FirebaseAuth/Sources/Utilities/FIRAuthErrorUtils.m

@@ -630,6 +630,9 @@
     @"Login credentials invalid. It is possible that the email/password combination does not "
     @"exist.";
 
+static NSString *const kFIRAuthErrorMessageMissingPasskeyEnrollment =
+    @"Cannot find the passkey linked to the current account.";
+
 /** @var FIRAuthErrorDescription
     @brief The error descrioption, based on the error code.
     @remarks No default case so that we get a compiler warning if a new value was added to the enum.
@@ -814,6 +817,8 @@
       return kFIRAuthErrorMessageInvalidReqType;
     case FIRAuthErrorCodeRecaptchaSDKNotLinked:
       return kFIRAuthErrorMessageRecaptchaSDKNotLinked;
+    case FIRAuthErrorCodePasskeyEnrollmentNotFound:
+      return kFIRAuthErrorMessageMissingPasskeyEnrollment;
   }
 }
 
@@ -1001,6 +1006,8 @@
       return @"ERROR_INVALID_REQ_TYPE";
     case FIRAuthErrorCodeRecaptchaSDKNotLinked:
       return @"ERROR_RECAPTCHA_SDK_NOT_LINKED";
+    case FIRAuthErrorCodePasskeyEnrollmentNotFound:
+      return @"ERROR_PASSKEY_ENROLLMENT_NOT_FOUND";
   }
 }
 
@@ -1239,6 +1246,10 @@ + (NSError *)userNotFoundErrorWithMessage:(nullable NSString *)message {
   return [self errorWithCode:FIRAuthInternalErrorCodeUserNotFound message:message];
 }
 
++ (NSError *)passkeyEnrollmentNotFoundError {
+  return [self errorWithCode:FIRAuthInternalPasskeyEnrollmentNotFound];
+}
+
 + (NSError *)invalidAPIKeyError {
   return [self errorWithCode:FIRAuthInternalErrorCodeInvalidAPIKey];
 }

FirebaseAuth/Sources/Utilities/FIRAuthInternalErrors.h

@@ -175,6 +175,12 @@ typedef NS_ENUM(NSInteger, FIRAuthInternalErrorCode) {
    */
   FIRAuthInternalErrorCodeUserNotFound = FIRAuthPublicErrorCodeFlag | FIRAuthErrorCodeUserNotFound,
 
+  /** @var FIRAuthInternalPasskeyEnrollmentNotFound
+      @brief Indicates the  given credential ID doesn't exist for passkey withdrawal.
+   */
+  FIRAuthInternalPasskeyEnrollmentNotFound = FIRAuthPublicErrorCodeFlag |
+                                             FIRAuthErrorCodePasskeyEnrollmentNotFound,
+
   /** @var FIRAuthInternalErrorCodeInvalidAPIKey
       @brief Indicates an invalid API Key was supplied in the request.
    */