Skip to content

Commit

Permalink
umbrella header fix
Browse files Browse the repository at this point in the history
  • Loading branch information
paulb777 committed Oct 28, 2024
1 parent de4c258 commit e7fda99
Show file tree
Hide file tree
Showing 26 changed files with 24 additions and 28 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@
#import "SharedTestUtilities/FIROptionsMock.h"

// Firebase Core
#import "FirebaseCore/Extension/FirebaseCoreExtension.h"
#import "FirebaseCore/Extension/CoreExtension.h"
File renamed without changes.
4 changes: 0 additions & 4 deletions FirebaseCore/InternalObjC/FirebaseCoreInternal.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

@import FirebaseCore;

#import "FIRAppInternal.h"
#import "FIRComponent.h"
#import "FIRComponentContainer.h"
#import "FIRComponentType.h"
#import "FIRHeartbeatLogger.h"
#import "FIRLibrary.h"
#import "FIRLogger.h"
2 changes: 1 addition & 1 deletion FirebaseCore/Sources/FIRApp.m
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

#import "FirebaseCore/Sources/Public/FirebaseCore/FIRApp.h"

@import FirebaseCoreInternal;
#import "FirebaseCore/InternalObjC/FirebaseCoreInternal.h"
#if SWIFT_PACKAGE
@import FirebaseCoreInternalObjC;
#endif
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#import "FirebaseCore/Extension/FirebaseCoreExtension.h"
#import "FirebaseCore/Extension/CoreExtension.h"
#import "SharedTestUtilities/ExceptionCatcher.h"
#import "SharedTestUtilities/FIROptionsMock.h"
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

#import <XCTest/XCTest.h>

#import "FirebaseCore/Extension/FirebaseCoreExtension.h"
#import "FirebaseCore/Extension/CoreExtension.h"
#import "FirebaseFunctions/Tests/ObjCIntegration/FIRFunctions+Internal.h"

@import FirebaseFunctions;
Expand Down
2 changes: 1 addition & 1 deletion FirebaseMessaging/Sources/FIRMessagingUtilities.m
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

#import <GoogleUtilities/GULAppEnvironmentUtil.h>
#import <GoogleUtilities/GULUserDefaults.h>
#import "FirebaseCore/Extension/FirebaseCoreExtension.h"
#import "FirebaseCore/Extension/CoreExtension.h"
#import "FirebaseMessaging/Sources/FIRMessagingLogger.h"

NSString *const kFIRMessagingInstanceIDUserDefaultsKeyLocale =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
#import "FirebaseMessaging/Sources/Token/FIRMessagingCheckinPreferences.h"
#import "FirebaseMessaging/Sources/Token/FIRMessagingTokenOperation.h"

#import "FirebaseCore/Extension/FirebaseCoreExtension.h"
#import "FirebaseCore/Extension/CoreExtension.h"

// We can have a static int since this error should theoretically only
// happen once (for the first time). If it repeats there is something
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
#import <OCMock/OCMock.h>

#import <GoogleUtilities/GULUserDefaults.h>
#import "FirebaseCore/Extension/FirebaseCoreExtension.h"
#import "FirebaseCore/Extension/CoreExtension.h"
#import "FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessaging.h"
#import "Interop/Analytics/Public/FIRAnalyticsInterop.h"

Expand Down
2 changes: 1 addition & 1 deletion FirebaseMessaging/Tests/UnitTests/FIRMessagingTest.m
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#import <XCTest/XCTest.h>

#import <GoogleUtilities/GULUserDefaults.h>
#import "FirebaseCore/Extension/FirebaseCoreExtension.h"
#import "FirebaseCore/Extension/CoreExtension.h"
#import "FirebaseMessaging/Sources/FIRMessaging_Private.h"
#import "FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessaging.h"
#import "FirebaseMessaging/Sources/Token/FIRMessagingTokenManager.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
#import <OCMock/OCMock.h>

#import <GoogleUtilities/GULUserDefaults.h>
#import "FirebaseCore/Extension/FirebaseCoreExtension.h"
#import "FirebaseCore/Extension/CoreExtension.h"
#import "FirebaseInstallations/Source/Library/Private/FirebaseInstallationsInternal.h"
#import "FirebaseMessaging/Sources/FIRMessagingPubSub.h"
#import "FirebaseMessaging/Sources/FIRMessagingRmqManager.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
#import <XCTest/XCTest.h>

#import <OCMock/OCMock.h>
#import "FirebaseCore/Extension/FirebaseCoreExtension.h"
#import "FirebaseCore/Extension/CoreExtension.h"
#import "FirebaseMessaging/Sources/FIRMessagingUtilities.h"
#import "FirebaseMessaging/Sources/Token/FIRMessagingAPNSInfo.h"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

#import <OCMock/OCMock.h>

#import "FirebaseCore/Extension/FirebaseCoreExtension.h"
#import "FirebaseCore/Extension/CoreExtension.h"
#import "FirebaseInstallations/Source/Library/Private/FirebaseInstallationsInternal.h"
#import "FirebaseMessaging/Sources/FIRMessagingConstants.h"
#import "FirebaseMessaging/Sources/NSError+FIRMessaging.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#import "FirebasePerformance/Sources/Configurations/FPRRemoteConfigFlags+Private.h"
#import "FirebasePerformance/Sources/Configurations/FPRRemoteConfigFlags.h"

#import "FirebaseCore/Extension/FirebaseCoreExtension.h"
#import "FirebaseCore/Extension/CoreExtension.h"

FPRConfigName kFPRConfigDataCollectionEnabled = @"dataCollectionEnabled";

Expand Down
2 changes: 1 addition & 1 deletion FirebasePerformance/Tests/Unit/Fakes/FIRAppFake.m
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

#import "FirebasePerformance/Tests/Unit/Fakes/FIRAppFake.h"

#import "FirebaseCore/Extension/FirebaseCoreExtension.h"
#import "FirebaseCore/Extension/CoreExtension.h"

@implementation FIRAppFake

Expand Down
2 changes: 1 addition & 1 deletion FirebaseRemoteConfig/Sources/RCNDevice.m
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
#import <sys/utsname.h>

#import <GoogleUtilities/GULAppEnvironmentUtil.h>
#import "FirebaseCore/Extension/FirebaseCoreExtension.h"
#import "FirebaseCore/Extension/CoreExtension.h"
#import "FirebaseRemoteConfig/Sources/Private/RCNConfigSettings.h"
#import "FirebaseRemoteConfig/Sources/RCNConfigConstants.h"

Expand Down
2 changes: 1 addition & 1 deletion FirebaseRemoteConfig/Sources/RCNUserDefaultsManager.m
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

#import "FirebaseRemoteConfig/Sources/RCNUserDefaultsManager.h"
#import "FirebaseCore/Extension/FirebaseCoreExtension.h"
#import "FirebaseCore/Extension/CoreExtension.h"
#import "FirebaseRemoteConfig/Sources/Public/FirebaseRemoteConfig/FIRRemoteConfig.h"
#import "FirebaseRemoteConfig/Sources/RCNConfigConstants.h"

Expand Down
2 changes: 1 addition & 1 deletion FirebaseRemoteConfig/Tests/Unit/RCNConfigDBManagerTest.m
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

#import <sqlite3.h>

#import "FirebaseCore/Extension/FirebaseCoreExtension.h"
#import "FirebaseCore/Extension/CoreExtension.h"
#import "FirebaseRemoteConfig/Sources/Private/RCNConfigSettings.h"
#import "FirebaseRemoteConfig/Sources/RCNConfigConstants.h"
#import "FirebaseRemoteConfig/Sources/RCNConfigContent.h"
Expand Down
2 changes: 1 addition & 1 deletion FirebaseRemoteConfig/Tests/Unit/RCNPersonalizationTest.m
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
#import <OCMock/OCMock.h>
#import <XCTest/XCTest.h>

#import "FirebaseCore/Extension/FirebaseCoreExtension.h"
#import "FirebaseCore/Extension/CoreExtension.h"
#import "FirebaseRemoteConfig/Sources/Private/FIRRemoteConfig_Private.h"
#import "FirebaseRemoteConfig/Sources/Private/RCNConfigFetch.h"
#import "FirebaseRemoteConfig/Sources/RCNConfigConstants.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#import <XCTest/XCTest.h>

// #import "FIRRemoteConfig+FIRApp.h"
#import "FirebaseCore/Extension/FirebaseCoreExtension.h"
#import "FirebaseCore/Extension/CoreExtension.h"
#import "FirebaseRemoteConfig/Sources/Private/FIRRemoteConfig_Private.h"
// #import "third_party/firebase/ios/Releases/FirebaseCore/Tests/FIRTestCase.h"

Expand Down
2 changes: 1 addition & 1 deletion FirebaseRemoteConfig/Tests/Unit/RCNRemoteConfigTest.m
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
#import "FirebaseRemoteConfig/Tests/Unit/RCNTestUtilities.h"

#import <GoogleUtilities/GULNSData+zlib.h>
#import "FirebaseCore/Extension/FirebaseCoreExtension.h"
#import "FirebaseCore/Extension/CoreExtension.h"
@import FirebaseRemoteConfigInterop;

@protocol FIRRolloutsStateSubscriber;
Expand Down
2 changes: 1 addition & 1 deletion FirebaseRemoteConfig/Tests/Unit/RCNThrottlingTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
#import "FirebaseRemoteConfig/Sources/RCNConfigExperiment.h"
#import "FirebaseRemoteConfig/Tests/Unit/RCNTestUtilities.h"

#import "FirebaseCore/Extension/FirebaseCoreExtension.h"
#import "FirebaseCore/Extension/CoreExtension.h"
@import FirebaseRemoteConfigInterop;

@interface RCNThrottlingTests : XCTestCase {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
@import FirebaseAuth;
@import FirebaseStorage;

#import "FirebaseCore/Extension/FirebaseCoreExtension.h"
#import "FirebaseCore/Extension/CoreExtension.h"

#import "FirebaseStorage/Tests/ObjCIntegration/Credentials.h"

Expand Down
2 changes: 1 addition & 1 deletion HeadersImports.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ In Swift Package Manager, it's a library target.
import like `#import "publicHeader.h"` to avoid public module collisions.

* *Private Headers from other Libraries* - Import a private umbrella header like
`FirebaseCore/Extension/FirebaseCoreExtension.h`. For CocoaPods, these files should be
`FirebaseCore/Extension/CoreExtension.h`. For CocoaPods, these files should be
added to the podspec in the `source_files` attribute like:
```
s.source_files = [ 'FirebaseFoo/Sources/**/*.[mh]'
Expand Down
2 changes: 1 addition & 1 deletion Interop/FirebaseComponentSystem.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ Each Firebase framework should register with Core in the `+load` method of the c
dependencies before a class has a chance to be called by a developer (if called at all).

```obj-c
#import "FirebaseCore/Extension/FirebaseCoreExtension.h"
#import "FirebaseCore/Extension/CoreExtension.h"

@interface FIRFoo <FIRLibrary>
@end
Expand Down
2 changes: 1 addition & 1 deletion SharedTestUtilities/FIRSampleAppUtilities.m
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#import <SafariServices/SafariServices.h>
#endif

#import "FirebaseCore/Extension/FirebaseCoreExtension.h"
#import "FirebaseCore/Extension/CoreExtension.h"

NSString *const kGoogleAppIDPlistKey = @"GOOGLE_APP_ID";
// Dummy plist GOOGLE_APP_ID
Expand Down

0 comments on commit e7fda99

Please sign in to comment.