Add doc diff to CI #10357
Closed
Add doc diff to CI #10357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganchen12
force-pushed
the
mc/docc
branch
2 times, most recently
from
5c22409 to
70a08ad
Compare
|
Note to self: check out |
morganchen12
force-pushed
the
mc/docc
branch
6 times, most recently
from
4dd4fb7 to
cc936b9
Compare
Coverage Report 1Affected Products
Test Logs |
morganchen12
force-pushed
the
mc/docc
branch
3 times, most recently
from
526a54d to
d8ae69f
Compare
morganchen12
force-pushed
the
mc/docc
branch
2 times, most recently
from
df75ed0 to
bfbae1c
Compare
paulb777
approved these changes
Apr 6, 2023
| run: git checkout master && bundle exec pod gen FirebaseStorage.podspec --local-sources=./ --platforms=ios | ||
| - name: Build documentation | ||
| working-directory: firebase-ios-sdk | ||
| run: xcodebuild docbuild -workspace gen/FirebaseStorage/FirebaseStorage.xcworkspace -scheme FirebaseStorage -sdk iphonesimulator -derivedDataPath ${{ env.ARTIFACTS_DIR }}/main/ |
There was a problem hiding this comment.
Since iOS docs are almost always a superset, should we deal with other platforms as notes in the actual doc source?
| @@ -156,3 +156,37 @@ jobs: | |||
| run: scripts/setup_bundler.sh | |||
| - name: PodLibLint Storage Cron | |||
| run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseStorage.podspec --platforms=${{ matrix.target }} --use-static-frameworks --skip-tests | |||
|
|
|||
| doc-diff: | |||
There was a problem hiding this comment.
Should we consolidate the steps into a script so we can inject less into each product's yml file?
Generated by 🚫 Danger |
|
Please close, merge, or comment. We plan to close stale PRs on November 28, 2023. |
|
I'll revisit this another time. We haven't moved to docc yet because it's unable to generate ObjC docs from Swift. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds doc build and diff to CI for Storage.