Auth swift checkpoint test #11533
Closed
Auth swift checkpoint test #11533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5f5ea48.
This reverts commit 02f83df.
* Attempt at merging own ported swift code to official repo * Fix: networkError was accidentally marked as internal. * Added Copyright notices * Moved base64 encoding extension. Reformatted a few todos * Converted a bit of MultiFactor * Added VerifyPhoneNumberRequest/Response and AuthOperationType
…10755) * Private header exposed to internal Swift impl via private module * Include all non-public headers in private module map * Add TODO and #if out import * Prefer <...> imports and fix API visibility. See more... - The private module map enables us to selectively expose non-public headers to Swift. Now, the internal APIs that were made public for the sake of exposing to Swift can be made internal again. Swift files that need access to non-public API should do the following: @_implementationOnly import FirebaseAuth_Private - Additionally, any public header imported into a non-public header needs to use <...> syntax because the header is technically coming from a different module (FirebaseAuth rather than FirebaseAuth_Private). * Fix import typo * Style * More progress. Building for CocoaPods. Not for SPM * Remove 'MyPrivateClass.h' * Generate private module map * Generate private module map followup * Re-enable testing spec * Style * Remove unneeded module.modulemap * Revert "Remove unneeded module.modulemap" This reverts commit 3ac44c3. * Adjust header import since FIRAuthBackend was moved * Get library building on iOS * Builds on iOS * Revert private module map and update gitignore * Add TODO * Wrap FirebaseAuth_Private import with #if COCOAPODS * Modularize script with arg[0] for podspec name * Generalize script more and remove private module map * Revert unintentionally checked in changes * re-style @objc(...) qualifier * Fix check * Fix SPM build * Change API back to what it was originally * Fix copyright * Better error handling in script
Co-authored-by: Nick Cooke <[email protected]>
|
Closing in favor of #13229 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a long-lived branch for reimplementing FirebaseAuth in Swift