Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Refactor Swift sources out of FirebaseRemoteConfigSwift #11747

Merged
merged 6 commits into from
Aug 29, 2023

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Aug 29, 2023

Addresses one follow-up work item from #11720

  • Moved the Swift sources out of FirebaseRemoteConfigSwift/Sources/ -> new FirebaseRemoteConfig/Swift/ dir.
  • Moved module re-exporter: FirebaseRemoteConfigSwift/Exporter/Exporter.swift -> FirebaseRemoteConfigSwift/Sources/FirebaseRemoteConfigSwift.swift now that the other RC-specific sources are gone from the RCSwift dir.

#no-changelog

@ncooke3 ncooke3 requested a review from andrewheard August 29, 2023 21:07
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2023

Apple API Diff Report

Commit: 5bcd6ec
Last updated: Tue Aug 29 14:15 PDT 2023
View workflow logs & download artifacts


[ADDED] FirebaseRemoteConfigSwift

[ADDED] FirebaseRemoteConfigSwift

Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM on green.

@ncooke3 ncooke3 merged commit 1dc90cd into master Aug 29, 2023
@ncooke3 ncooke3 deleted the nc/rc-pod-merge-non-breaking-4 branch August 29, 2023 21:49
ncooke3 added a commit that referenced this pull request Sep 1, 2023
@firebase firebase locked and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants