Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add const for target index matcher #11760

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Add const for target index matcher #11760

merged 1 commit into from
Aug 31, 2023

Conversation

cherylEnkidu
Copy link
Contributor

@cherylEnkidu cherylEnkidu commented Aug 30, 2023 •
edited
Loading

#no-changelog

@cherylEnkidu cherylEnkidu requested a review from dconeybe August 30, 2023 22:36
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.13% (1dc90cd) to 88.13% (b7b6c17) by -0.00%.

    FilenameBase (1dc90cd)Merge (b7b6c17)Diff
    filesystem_posix.cc79.09%81.82%+2.73%
    leveldb_remote_document_cache.cc96.55%94.83%-1.72%
    task.cc94.78%93.91%-0.87%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/k6QkvQUFye.html

@dconeybe dconeybe assigned cherylEnkidu and unassigned dconeybe Aug 31, 2023
@cherylEnkidu cherylEnkidu merged commit 2edb91c into master Aug 31, 2023
@cherylEnkidu cherylEnkidu deleted the cheryllin/add-const branch August 31, 2023 17:52
andrewheard pushed a commit that referenced this pull request Sep 20, 2023
@cherylEnkidu @andrewheard
Add const for target index matcher (#11760)
3eee549
@firebase firebase locked and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@cherylEnkidu cherylEnkidu

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cherylEnkidu @google-oss-bot @dconeybe