Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Revert merge of ConfigSwift into Config #11769

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Sep 1, 2023

Need more time to get API approval.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Apple API Diff Report

Commit: af0ec79
Last updated: Fri Sep 1 11:29 PDT 2023
View workflow logs & download artifacts


FirebaseRemoteConfigSwift

[ADDED] Structures
Swift:
+    @available(iOS 14.0, macOS 11.0, tvOS 14.0, watchOS 7.0, *) @propertyWrapper public struct RemoteConfigProperty < T > : DynamicProperty where T : Decodable
+      public let key : String
+      public var wrappedValue : T { get }
+      public init ( key : String , fallback : T )
[ADDED] Extensions
Swift:
+    public extension RemoteConfig
+      func decoded < Value > ( asType : Value . Type = Value . self ) throws -> Value where Value : Decodable
+      func setDefaults < Value > ( from value : Value ) throws where Value : Encodable
+      subscript < T > ( decodedValue key : String ) -> T ? where T : Decodable { get }
+      subscript ( jsonValue key : String ) -> [ String : AnyHashable ]? { get }
+    public extension RemoteConfigValue
+      func decoded < Value > ( asType : Value . Type = Value . self ) throws -> Value where Value : Decodable
[ADDED] Enumerations
Swift:
+    public enum RemoteConfigCodableError : Error
+      case invalidSetDefaultsInput ( String )
+    public enum RemoteConfigValueCodableError : Error
+      case unsupportedType ( String )

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseRemoteConfig-iOS-FirebaseRemoteConfig.framework

    Overall coverage changed from 72.24% (d12eb34) to 73.88% (af0ec79) by +1.65%.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/CJ8lAWhgxe.html

@ncooke3 ncooke3 merged commit acfd28c into master Sep 1, 2023
64 of 65 checks passed
@ncooke3 ncooke3 deleted the nc/revert-rc-merge branch September 1, 2023 20:12
@firebase firebase locked and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants