Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More fixes for AppCheckInterop #11813

Merged
merged 2 commits into from
Sep 15, 2023
Merged

More fixes for AppCheckInterop #11813

merged 2 commits into from
Sep 15, 2023

Conversation

paulb777
Copy link
Member

Follow up to #11812

Changing the podspec to get FirebaseAppCheckInterop via the module means that the module should be imported instead of the headers.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseDatabase-iOS-FirebaseDatabase.framework

    Overall coverage changed from 56.95% (51b29ed) to 56.94% (50e6b12) by -0.01%.

    FilenameBase (51b29ed)Merge (50e6b12)Diff
    FSRWebSocket.m38.29%38.14%-0.15%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EGgmvA2eF6.html

@paulb777 paulb777 requested a review from ncooke3 September 15, 2023 18:33
@paulb777 paulb777 merged commit 455de9c into master Sep 15, 2023
59 checks passed
@paulb777 paulb777 deleted the pb-db-ac-interop2 branch September 15, 2023 18:35
@paulb777 paulb777 mentioned this pull request Sep 16, 2023
Closed
andrewheard pushed a commit that referenced this pull request Sep 20, 2023
@paulb777 @andrewheard
More fixes for AppCheckInterop (#11813)
dcbf99f
@firebase firebase locked and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
api: database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @google-oss-bot @ncooke3