Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Passkey #4] finalizePasskeySignIn rpc #11904

Merged
merged 2 commits into from
Oct 9, 2023
Merged

[Passkey #4] finalizePasskeySignIn rpc #11904

merged 2 commits into from
Oct 9, 2023

Conversation

Xiaoshouzi-gh
Copy link
Contributor

  1. Implemented the call to finalizePasskeySignIn RPC
  2. Defined finalizePasskeySignInRequest & Response
  3. Added unit tests
    This flow has been tested against backend staging endpoint.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@Xiaoshouzi-gh Xiaoshouzi-gh marked this pull request as ready for review October 6, 2023 18:11
@Xiaoshouzi-gh Xiaoshouzi-gh merged commit d89ca8c into passkey-main Oct 9, 2023
@Xiaoshouzi-gh Xiaoshouzi-gh deleted the passkey-finalize-signin branch October 9, 2023 16:10
@firebase firebase locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@renkelvin renkelvin renkelvin approved these changes

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xiaoshouzi-gh @google-oss-bot @renkelvin