Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[auth-swift] Fix TOTP for building in extensions #11909

Merged
merged 2 commits into from
Oct 9, 2023
Merged

[auth-swift] Fix TOTP for building in extensions #11909

merged 2 commits into from
Oct 9, 2023

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Oct 6, 2023

Swift implementation of #11554

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@paulb777
Copy link
Member Author

paulb777 commented Oct 7, 2023

Verified the change addresses a build failure on an extension target

@paulb777
Copy link
Member Author

paulb777 commented Oct 9, 2023

Merging now. I'll address any comments in a future PR on the auth-swift branch.

@paulb777 paulb777 merged commit abcbae7 into auth-swift Oct 9, 2023
29 checks passed
@paulb777 paulb777 deleted the pb-totp-extensions branch October 9, 2023 17:12
@firebase firebase locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 left review comments

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @google-oss-bot @ncooke3