Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Config] Update FirebaseRemoteConfigSwift.podspec #11936

Merged
merged 1 commit into from
Oct 23, 2023
Merged

[Config] Update FirebaseRemoteConfigSwift.podspec #11936

merged 1 commit into from
Oct 23, 2023

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Oct 13, 2023

Remove unneeded FirebaseCore import (see convo here)

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseRemoteConfig-iOS-FirebaseRemoteConfig.framework

    Overall coverage changed from ? (85f4f03) to 72.24% (22a0262) by ?.

    18 individual files with coverage change

    FilenameBase (85f4f03)Merge (22a0262)Diff
    Codable.swift?0.00%?
    FIRConfigValue.m?58.70%?
    FirebaseRemoteConfigValueDecoderHelper.swift?0.00%?
    FIRRemoteConfig.m?83.91%?
    FIRRemoteConfigComponent.m?97.06%?
    FIRRemoteConfigUpdate.m?100.00%?
    RCNConfigContent.m?81.90%?
    RCNConfigDBManager.m?76.43%?
    RCNConfigExperiment.m?86.55%?
    RCNConfigFetch.m?74.13%?
    RCNConfigRealtime.m?50.63%?
    RCNConfigSettings.m?62.81%?
    RCNDevice.m?81.29%?
    RCNPersonalization.m?89.74%?
    RCNUserDefaultsManager.m?98.43%?
    RemoteConfigProperty.swift?0.00%?
    RemoteConfigValueObservable.swift?0.00%?
    Value.swift?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/1ZeIQgjaQh.html

@ncooke3
Copy link
Member Author

ncooke3 commented Oct 13, 2023

The CI failure looks real, yet didn't surface in #11808 (success).

In order for the binary Firestore binary distro to work, SharedSwift had to be made a binary. But, this means building for watchOS with SPM becomes problematic since the SharedSwift xcframework does not have a watchOS slice.

@ncooke3 ncooke3 mentioned this pull request Oct 13, 2023
Merged
@ncooke3
Copy link
Member Author

ncooke3 commented Oct 23, 2023 •
edited
Loading

Ugh, I never came back to this after investigating the issue in the above comment. This PR should merge but I'm not sure it's worth the re-spin for making it into M139. It's removing an unneeded Core dependency that will already be there via the dependency on FirebaseRemoteConfig. Previously, this explicit Core dependency was needed, but is no more after the consolidation. cc: @paulb777

@paulb777
Copy link
Member

While this is the correct change, I can't think of any practical case where it will make a difference, so I recommend merging, but no reason to respin a release candidate.

@ncooke3 ncooke3 merged commit 5661bab into master Oct 23, 2023
56 checks passed
@ncooke3 ncooke3 deleted the ncooke3-patch-2 branch October 23, 2023 21:29
@firebase firebase locked and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: remoteconfig
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncooke3 @google-oss-bot @paulb777