Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[visionOS] Fix Crashlytics build on Xcode 15.1 beta 1 #11938

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

andrewheard
Copy link
Contributor

In Xcode 15.1 TARGET_OS_IOS is now 0 instead of 1 on visionOS. This PR fixes the build and for Crashlytics on Xcode 15.1 beta 1 / visionOS.

Note: google/GoogleUtilities#132 is also needed to fix the build (not yet tagged / released).

#no-changelog

@andrewheard andrewheard marked this pull request as ready for review October 13, 2023 21:20
@andrewheard andrewheard merged commit 579914e into master Oct 17, 2023
49 checks passed
@andrewheard andrewheard deleted the ah/visionos-crashlytics branch October 17, 2023 18:03
@Brooksie18
Copy link

Brooksie18 commented Oct 17, 2023 via email

@Brooksie18
Copy link

Brooksie18 commented Oct 17, 2023 via email

@themiswang themiswang mentioned this pull request Oct 19, 2023
@firebase firebase locked and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants