[auth-swift] Recaptcha Enterprise integration #11942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
changed the title
Generated by 🚫 Danger |
paulb777
force-pushed
the
pb-swift-recaptcha
branch
2 times, most recently
from
7c54175 to
e049c5f
Compare
paulb777
force-pushed
the
pb-swift-recaptcha
branch
from
e049c5f to
6c29a2d
Compare
ncooke3
approved these changes
Oct 26, 2023
andrewheard
approved these changes
Oct 26, 2023
renkelvin
approved these changes
Oct 26, 2023
| @@ -30,47 +30,63 @@ private let kIdentityPlatformStagingAPIHost = | |||
|
|
|||
| /// Represents a request to an identity toolkit endpoint. | |||
| @available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *) | |||
| open class IdentityToolkitRequest { | |||
There was a problem hiding this comment.
I'm curious why these keywords are no longer needed?
There was a problem hiding this comment.
Extra public visibility was necessary for porting when the library was a mix of Objective C and Swift. Now that it is all Swift, the access can be corrected.
A full review of all the access specifiers across all the sources is on the TODO list.
This was referenced Nov 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplementation of #11681
Also one-line fix from #11698
It's especially interesting to see how much async/await improves the Auth.swift vs FIRAuth.m changes and how much more understandable the reflection/protocol implementation is in AuthRecaptchaVerifier.swift.
The sample change is done but only partly tested. I added a todo to https://docs.google.com/spreadsheets/d/1o2DqFu9q-o4dWTcbHywHiB_Pi02A7-bSjVe2Odxqcdo/edit?pli=1&resourcekey=0-FZN_D-sDn3MmZTkK3OdRsw#gid=0