Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update comments #11968

Merged
merged 1 commit into from
Oct 19, 2023
Merged

update comments #11968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Crashlytics/Crashlytics/Components/FIRCLSApplication.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ NSString* FIRCLSApplicationGetSDKBundleID(void);
/**
* Returns the platform identifier, either: ios, mac, or tvos.
* Catalyst apps are treated as mac.
* This is a legacy function, for platform identificaiton please use
* FIRCLSApplicationGetFirebasePlatform.
*/
NSString* FIRCLSApplicationGetPlatform(void);

Expand Down
6 changes: 4 additions & 2 deletions Crashlytics/Crashlytics/Components/FIRCLSApplication.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@
[@"com.google.firebase.crashlytics." stringByAppendingString:FIRCLSApplicationGetPlatform()];
}

// Legacy function, we use FIRCLSApplicationGetFirebasePlatform now for platform specification.
// Can't clean the code since some endpoints setup depend on this function.
NSString* FIRCLSApplicationGetPlatform(void) {
#if defined(TARGET_OS_MACCATALYST) && TARGET_OS_MACCATALYST
return @"mac";
Expand All @@ -47,9 +49,9 @@
#elif TARGET_OS_TV
return @"tvos";
#elif TARGET_OS_WATCH
return @"ios"; // TODO: temporarily use iOS until Firebase can add watchos to the backend
return @"ios";
#elif defined(TARGET_OS_VISION) && TARGET_OS_VISION
return @"ios"; // TODO: temporarily use iOS until Firebase can add visionos to the backend
andrewheard marked this conversation as resolved.
Show resolved Hide resolved
return @"ios";
#endif
}

Expand Down