Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sign up endpoint for link with email password (resubmit #11925) #12009

Merged
merged 14 commits into from
Nov 1, 2023
Merged

Use sign up endpoint for link with email password (resubmit #11925) #12009

merged 14 commits into from
Nov 1, 2023

Conversation

renkelvin
Copy link
Contributor

@renkelvin renkelvin commented Oct 26, 2023 •
edited
Loading

Fix #11911

@renkelvin renkelvin changed the title Link email Use sign up endpoint for link with email password (resubmit #11925) Oct 26, 2023
@google-oss-bot
Copy link

google-oss-bot commented Oct 26, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseAuth-iOS-FirebaseAuth.framework

    Overall coverage changed from 68.36% (90846d5) to 68.53% (b51d44c) by +0.17%.

    FilenameBase (90846d5)Merge (b51d44c)Diff
    FIRAuth.m82.78%83.68%+0.89%
    FIRAuthKeychainServices.m52.36%58.80%+6.44%
    FIRAuthStoredUserManager.m27.59%52.87%+25.29%
    FIRSignUpNewUserRequest.m95.92%96.30%+0.38%
    FIRUser.m71.07%69.50%-1.57%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/a2qQdY7LiF.html

paulb777
paulb777 reviewed Oct 26, 2023
View reviewed changes
FirebaseAuth/CHANGELOG.md Outdated Show resolved Hide resolved
@renkelvin renkelvin marked this pull request as ready for review October 30, 2023 17:33
@renkelvin renkelvin requested a review from prameshj October 30, 2023 17:33
@renkelvin renkelvin merged commit 6673e7c into master Nov 1, 2023
49 checks passed
@renkelvin renkelvin deleted the link-email branch November 1, 2023 20:10
@paulb777 paulb777 added this to the 10.18.0 - M140 milestone Nov 2, 2023
paulb777
paulb777 reviewed Nov 4, 2023
View reviewed changes
FirebaseAuth/Sources/User/FIRUser.m
callInMainThreadWithAuthDataResultAndError(completion, nil, keychainError);
return;
}
[self signOutIfTokenIsInvalidWithError:error];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renkelvin This line looks like a no-op since error must be nil based on the return at line 1123

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I think you're right. Let me remove it. Thanks!

@paulb777 paulb777 mentioned this pull request Nov 8, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 left review comments

@prameshj prameshj prameshj approved these changes

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
10.18.0 - M140
Development

Successfully merging this pull request may close these issues.

Anonymous Auth Verify Can't Connect Account for Email / Password
4 participants
@renkelvin @google-oss-bot @paulb777 @prameshj