Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace FIRDeviceCheckAPIServiceE2ETests with AppCheckE2ETests #12031

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Oct 31, 2023

AppCheckE2ETests uses a custom provider to test AppCheck.token(forcingRefresh:) since DeviceCheck is not available in a CI environment.

Note: This is already committed in the app-check-core branch (https://github.com/firebase/firebase-ios-sdk/blob/4da4c2e55f62f6aadc35fe340bb3d3a4b72b71fd/FirebaseAppCheck/Tests/Integration/AppCheckE2ETests.swift) but can be merged independently into master.

#no-changelog

@andrewheard andrewheard marked this pull request as ready for review October 31, 2023 22:15
@andrewheard andrewheard requested a review from paulb777 October 31, 2023 22:15
@andrewheard andrewheard merged commit 88d1530 into master Nov 1, 2023
62 checks passed
@andrewheard andrewheard deleted the ah/appcheck-e2e-tests branch November 1, 2023 14:38
@firebase firebase locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants