Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zip quickstart regression #12036

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Fix zip quickstart regression #12036

merged 1 commit into from
Nov 1, 2023

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Nov 1, 2023

This should fix recent failures in the zip tests trying to run quickstarts on the unavailable iPhone 15 with Xcode 14.2. iPhone 14 shows available in https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md and https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md

@ncooke3
Copy link
Member

ncooke3 commented Nov 1, 2023

zip tests trying to run quickstarts on the unavailable iPhone 15 with Xcode 14.2

Should the zip tests instead be pinned to using 14.1? Since 14.1 is our current minimum supported Xcode version.

@paulb777
Copy link
Member Author

paulb777 commented Nov 1, 2023

zip tests trying to run quickstarts on the unavailable iPhone 15 with Xcode 14.2

Should the zip tests instead be pinned to using 14.1? Since 14.1 is our current minimum supported Xcode version.

Not necessarily, most clients will be using something newer.

Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the zip tests instead be pinned to using 14.1? Since 14.1 is our current minimum supported Xcode version.

Not necessarily, most clients will be using something newer.

@paulb777 @ncooke3 I agree with both of your points but I checked our stats and Xcode 14.2 usage is significantly higher than 14.1 so I'd somewhat lean towards keeping it as is.

@paulb777 paulb777 merged commit c2250a4 into master Nov 1, 2023
36 checks passed
@paulb777 paulb777 deleted the pb-zip-test-fix branch November 1, 2023 17:38
@firebase firebase locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants