Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cmake ci #12071

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Fix cmake ci #12071

merged 2 commits into from
Nov 8, 2023

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Nov 8, 2023 •
edited
Loading

The default Python in CI changed recently. Fix inspired by #12055

Also update the source and header paths for GoogleUtilities

For some reason, most Firestore jobs are not running in nightlies, but not clear to me why.

@andrewheard andrewheard self-requested a review November 8, 2023 00:11
andrewheard
andrewheard approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green. Thanks!

@google-oss-bot
Copy link

google-oss-bot commented Nov 8, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.10% (8329c4c) to 88.16% (7bd8774) by +0.06%.

    FilenameBase (8329c4c)Merge (7bd8774)Diff
    exception.cc23.68%84.21%+60.53%
    leveldb_key.cc98.82%98.14%-0.69%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/puVn48cIbe.html

@paulb777
Copy link
Member Author

paulb777 commented Nov 8, 2023

Merging since the cmake tests have succeeded.

cc: @wu-hui @milaGGL @ncooke3

@paulb777 paulb777 merged commit 0c1c1ca into master Nov 8, 2023
42 of 45 checks passed
@paulb777 paulb777 deleted the pb-cmake-ci branch November 8, 2023 01:35
@firebase firebase locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewheard andrewheard andrewheard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @google-oss-bot @andrewheard