Zip: Stop including Swift specific frameworks #12080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
Should this be treated as a breaking change? I'm wondering since it would likely break clients that have tooling to process the zip distribution. |
|
We have not treated changing dependencies in the zip as a breaking change. We consider the contract to be the README instructions - primarily, copying everything from the product directory. |
|
Confirmed manually the README changes and that the zip artifacts no longer include the five Swift.xcframeworks. Ready for review but will wait until 10.18.0 settles to merge. |
ncooke3
approved these changes
Nov 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Swift specific APIs are now distributed in the standard xcframeworks, there's no reason to include separate Swift xcframeworks in the zip distro.