Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redeclare protocol method so it can be added to docs #12142

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

morganchen12
Copy link
Contributor

See cl/585793441 for docsgen (googlers only). Addresses the lack of doc in this comment: #11284 (comment)

#no-changelog

Copy link
Contributor

github-actions bot commented Nov 28, 2023

Apple API Diff Report

Commit: a05c9a6
Last updated: Tue Nov 28 13:19 PST 2023
View workflow logs & download artifacts


FirebaseAppCheck

Classes

FIRDeviceCheckProvider
[ADDED] -getTokenWithCompletion:
Swift:
+  func getToken () async throws -> FIRAppCheckToken
Objective-C:
+  - ( void ) getTokenWithCompletion :( nonnull void ( ^ )( FIRAppCheckToken * _Nullable , NSError * _Nullable )) handler ;
[ADDED] -getLimitedUseTokenWithCompletion:
Swift:
+  func getLimitedUseToken () async throws -> FIRAppCheckToken
Objective-C:
+  - ( void ) getLimitedUseTokenWithCompletion : ( nonnull void ( ^ )( FIRAppCheckToken * _Nullable , NSError * _Nullable )) handler ;
FIRAppAttestProvider
[ADDED] -getTokenWithCompletion:
Swift:
+  func getToken () async throws -> FIRAppCheckToken
Objective-C:
+  - ( void ) getTokenWithCompletion :( nonnull void ( ^ )( FIRAppCheckToken * _Nullable , NSError * _Nullable )) handler ;
[ADDED] -getLimitedUseTokenWithCompletion:
Swift:
+  func getLimitedUseToken () async throws -> FIRAppCheckToken
Objective-C:
+  - ( void ) getLimitedUseTokenWithCompletion : ( nonnull void ( ^ )( FIRAppCheckToken * _Nullable , NSError * _Nullable )) handler ;
FIRAppCheckDebugProvider
[ADDED] -getTokenWithCompletion:
Swift:
+  func getToken () async throws -> FIRAppCheckToken
Objective-C:
+  - ( void ) getTokenWithCompletion :( nonnull void ( ^ )( FIRAppCheckToken * _Nullable , NSError * _Nullable )) handler ;
[ADDED] -getLimitedUseTokenWithCompletion:
Swift:
+  func getLimitedUseToken () async throws -> FIRAppCheckToken
Objective-C:
+  - ( void ) getLimitedUseTokenWithCompletion : ( nonnull void ( ^ )( FIRAppCheckToken * _Nullable , NSError * _Nullable )) handler ;

Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@andrewheard andrewheard merged commit fc42195 into master Nov 28, 2023
68 checks passed
@andrewheard andrewheard deleted the mc/appcheck branch November 28, 2023 22:29
@firebase firebase locked and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants