Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release Tooling] Stop sourcing .bash_profile when running generated shell scripts #12159

Merged
merged 3 commits into from
Dec 27, 2023

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Nov 30, 2023

See comment here (#12158 (comment)).

Going to let a global CI run finish and will re-evaluate then if this PR is worth it.

@ncooke3 ncooke3 marked this pull request as draft November 30, 2023 16:27
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@ncooke3 ncooke3 closed this Dec 20, 2023
@ncooke3 ncooke3 reopened this Dec 20, 2023
@ncooke3
Copy link
Member Author

ncooke3 commented Dec 26, 2023

Green global CI run in 3490a7a

@ncooke3 ncooke3 requested a review from paulb777 December 26, 2023 22:45
@ncooke3 ncooke3 marked this pull request as ready for review December 26, 2023 23:59
@ncooke3 ncooke3 merged commit 2a3fd2a into main Dec 27, 2023
5 checks passed
@ncooke3 ncooke3 deleted the nc/remove-bash-source branch December 27, 2023 00:00
@firebase firebase locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants