Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update firebase test lab GitHub Action #12178

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Update firebase test lab GitHub Action #12178

merged 3 commits into from
Dec 6, 2023

Conversation

sunmou99
Copy link
Contributor

@sunmou99 sunmou99 commented Dec 6, 2023 •
edited
Loading

Updated FTL GitHub Action: FirebaseExtended/github-actions#9

Discussion

FTL Action needs update

Testing

Test passed: https://github.com/firebase/firebase-ios-sdk/actions/runs/7118599545/job/19381950469#step:9:20

API Changes

@google-oss-bot
Copy link

google-oss-bot commented Dec 6, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseABTesting-iOS-FirebaseABTesting.framework

    Overall coverage changed from ? (0f73173) to 90.04% (0463063) by ?.

    FilenameBase (0f73173)Merge (0463063)Diff
    ABTConditionalUserPropertyController.m?90.05%?
    ABTExperimentPayload.m?100.00%?
    FIRExperimentController.m?83.73%?
    FIRLifecycleEvents.m?100.00%?

  • FirebaseDynamicLinks-iOS-FirebaseDynamicLinks.framework

    Overall coverage changed from ? (0f73173) to 61.52% (0463063) by ?.

    15 individual files with coverage change

    FilenameBase (0f73173)Merge (0463063)Diff
    FDLDeviceHeuristicsHelper.m?0.00%?
    FDLLogging.m?58.62%?
    FDLURLComponents.m?82.31%?
    FDLUtilities.m?75.40%?
    FIRDLDefaultRetrievalProcessV2.m?14.04%?
    FIRDLJavaScriptExecutor.m?24.81%?
    FIRDLRetrievalProcessFactory.m?100.00%?
    FIRDLRetrievalProcessResult.m?100.00%?
    FIRDLScionLogging.m?100.00%?
    FIRDynamicLink.m?74.07%?
    FIRDynamicLinkComponentsKeyProvider.m?83.33%?
    FIRDynamicLinkNetworking.m?45.09%?
    FIRDynamicLinks.m?71.30%?
    GINArgument.m?0.00%?
    GINInvocation.m?0.00%?

  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    Overall coverage changed from ? (0f73173) to 60.48% (0463063) by ?.

    29 individual files with coverage change

    FilenameBase (0f73173)Merge (0463063)Diff
    FIRMessaging.m?55.20%?
    FIRMessagingAnalytics.m?82.14%?
    FIRMessagingAPNSInfo.m?87.76%?
    FIRMessagingAuthKeychain.m?87.42%?
    FIRMessagingAuthService.m?92.03%?
    FIRMessagingBackupExcludedPlist.m?82.09%?
    FIRMessagingCheckinPreferences.m?98.02%?
    FIRMessagingCheckinService.m?86.49%?
    FIRMessagingCheckinStore.m?81.68%?
    FIRMessagingContextManagerService.m?85.71%?
    FIRMessagingExtensionHelper.m?77.92%?
    FIRMessagingKeychain.m?93.39%?
    FIRMessagingLogger.m?100.00%?
    FIRMessagingPendingTopicsList.m?88.24%?
    FIRMessagingPersistentSyncMessage.m?38.10%?
    FIRMessagingPubSub.m?52.14%?
    FIRMessagingRemoteNotificationsProxy.m?76.35%?
    FIRMessagingRmqManager.m?57.42%?
    FIRMessagingSyncMessageManager.m?68.89%?
    FIRMessagingTokenDeleteOperation.m?0.00%?
    FIRMessagingTokenFetchOperation.m?75.91%?
    FIRMessagingTokenInfo.m?73.91%?
    FIRMessagingTokenManager.m?14.82%?
    FIRMessagingTokenOperation.m?95.04%?
    FIRMessagingTokenStore.m?66.00%?
    FIRMessagingTopicOperation.m?0.00%?
    FIRMessagingUtilities.m?56.73%?
    NSDictionary+FIRMessaging.m?27.27%?
    NSError+FIRMessaging.m?100.00%?

  • FirebasePerformance-iOS-FirebasePerformance.framework

    Overall coverage changed from ? (0f73173) to 94.71% (0463063) by ?.

    43 individual files with coverage change

    FilenameBase (0f73173)Merge (0463063)Diff
    FIRHTTPMetric.m?100.00%?
    FIRPerformance.m?95.00%?
    FIRTrace.m?93.63%?
    FPRAppActivityTracker.m?93.08%?
    FPRClassInstrumentor.m?91.67%?
    FPRClient.m?94.49%?
    FPRConfiguration.m?63.16%?
    FPRConfigurations.m?95.00%?
    FPRConsoleURLGenerator.m?100.00%?
    FPRCounterList.m?100.00%?
    FPRCPUGaugeCollector.m?89.91%?
    FPRCPUGaugeData.m?100.00%?
    FPRDataUtils.m?96.04%?
    FPRDiagnostics.m?84.48%?
    FPRGaugeManager.m?95.42%?
    FPRGDTEvent.m?80.00%?
    FPRGDTLogger.m?100.00%?
    FPRGDTLogSampler.m?90.16%?
    FPRGDTRateLimiter.m?94.59%?
    FPRInstrument.m?100.00%?
    FPRInstrumentation.m?100.00%?
    FPRMemoryGaugeCollector.m?94.12%?
    FPRMemoryGaugeData.m?100.00%?
    FPRNanoPbUtils.m?86.53%?
    FPRNetworkInstrumentHelpers.m?29.17%?
    FPRNetworkTrace.m?95.25%?
    FPRNSURLConnectionDelegate.m?61.36%?
    FPRNSURLConnectionDelegateInstrument.m?98.70%?
    FPRNSURLConnectionInstrument.m?96.62%?
    FPRNSURLSessionDelegate.m?100.00%?
    FPRNSURLSessionDelegateInstrument.m?99.24%?
    FPRNSURLSessionInstrument.m?97.58%?
    FPRObjectInstrumentor.m?83.33%?
    FPRPerfDate.m?50.00%?
    FPRProxyObjectHelper.m?100.00%?
    FPRRemoteConfigFlags.m?98.09%?
    FPRScreenTraceTracker.m?97.69%?
    FPRSelectorInstrumentor.m?90.38%?
    FPRSessionDetails.m?96.43%?
    FPRSessionManager.m?100.00%?
    FPRTraceBackgroundActivityTracker.m?100.00%?
    FPRUIViewControllerInstrument.m?95.18%?
    FPRURLFilter.m?100.00%?

  • FirebaseStorage-iOS-FirebaseStorage.framework

    Overall coverage changed from ? (0f73173) to 0.00% (0463063) by ?.

    21 individual files with coverage change

    FilenameBase (0f73173)Merge (0463063)Diff
    AsyncAwait.swift?0.00%?
    Result.swift?0.00%?
    Storage.swift?0.00%?
    StorageComponent.swift?0.00%?
    StorageDeleteTask.swift?0.00%?
    StorageDownloadTask.swift?0.00%?
    StorageError.swift?0.00%?
    StorageGetDownloadURLTask.swift?0.00%?
    StorageGetMetadataTask.swift?0.00%?
    StorageListResult.swift?0.00%?
    StorageListTask.swift?0.00%?
    StorageMetadata.swift?0.00%?
    StorageObservableTask.swift?0.00%?
    StoragePath.swift?0.00%?
    StorageReference.swift?0.00%?
    StorageTask.swift?0.00%?
    StorageTaskSnapshot.swift?0.00%?
    StorageTokenAuthorizer.swift?0.00%?
    StorageUpdateMetadataTask.swift?0.00%?
    StorageUploadTask.swift?0.00%?
    StorageUtils.swift?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZicuXyvfOS.html

@sunmou99 sunmou99 self-assigned this Dec 6, 2023
@sunmou99 sunmou99 requested a review from paulb777 December 6, 2023 18:43
@sunmou99 sunmou99 marked this pull request as ready for review December 6, 2023 18:43
@sunmou99 sunmou99 enabled auto-merge (squash) December 6, 2023 18:44
paulb777
paulb777 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sunmou99 sunmou99 merged commit d724d30 into master Dec 6, 2023
196 checks passed
@sunmou99 sunmou99 deleted the update-ftl-action branch December 6, 2023 18:49
@paulb777 paulb777 mentioned this pull request Dec 7, 2023
Closed
@firebase firebase locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees

@sunmou99 sunmou99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunmou99 @google-oss-bot @paulb777