-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new firestore-nightly workflow #12180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine, with no customer facing consequence, so I will approve.
But how will we know this is working?
Generated by 🚫 Danger |
Coverage Report 1Affected Products
Test Logs |
The test outputs where it is connecting to, and the check is added as an optional CI workflow now. |
@wu-hui This job is both starting too late and consistently failing since added. Please address. https://github.com/firebase/firebase-ios-sdk/actions/workflows/firestore-nightly.yml |
Nightly is unstable, i am going to make this workflow an on-demand one, instead of a scheduled or PR run. |
Example run: https://github.com/firebase/firebase-ios-sdk/actions/runs/7132339153/job/19424930017?pr=12180
Note the tests failed due to some composite indexes missing, and nightly seems to have large serverTimestamp drifts.