Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new firestore-nightly workflow #12180

Merged
merged 8 commits into from
Dec 8, 2023
Merged

Add new firestore-nightly workflow #12180

merged 8 commits into from
Dec 8, 2023

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Dec 7, 2023

Example run: https://github.com/firebase/firebase-ios-sdk/actions/runs/7132339153/job/19424930017?pr=12180

Note the tests failed due to some composite indexes missing, and nightly seems to have large serverTimestamp drifts.

Copy link
Contributor

@tom-andersen tom-andersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, with no customer facing consequence, so I will approve.

But how will we know this is working?

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

google-oss-bot commented Dec 7, 2023

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.10% (d724d30) to 88.08% (597056c) by -0.02%.

    FilenameBase (d724d30)Merge (597056c)Diff
    filesystem_posix.cc81.82%79.09%-2.73%
    task.cc94.78%93.91%-0.87%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7X0PfwzLvs.html

@wu-hui
Copy link
Contributor Author

wu-hui commented Dec 8, 2023

This seems fine, with no customer facing consequence, so I will approve.

But how will we know this is working?

The test outputs where it is connecting to, and the check is added as an optional CI workflow now.

@wu-hui wu-hui merged commit 8ed02e9 into master Dec 8, 2023
52 checks passed
@wu-hui wu-hui deleted the wuandy/NightlyFirestore branch December 8, 2023 12:27
@paulb777
Copy link
Member

@wu-hui This job is both starting too late and consistently failing since added. Please address. https://github.com/firebase/firebase-ios-sdk/actions/workflows/firestore-nightly.yml

@wu-hui
Copy link
Contributor Author

wu-hui commented Dec 11, 2023

Nightly is unstable, i am going to make this workflow an on-demand one, instead of a scheduled or PR run.

ncooke3 pushed a commit that referenced this pull request Dec 15, 2023
@firebase firebase locked and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants