Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore: Increase clock skew tolerance in FIRServerTimestampTests.mm #12190

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Dec 12, 2023

In FIRServerTimestampTests.mm there is a check to verify that the server timestamp values generated by the backend are within 10 seconds of the time on the local device. This, however, appears to be too aggressive, even for production. Therefore, increase the tolerance to 200 seconds.

#no-changelog

@dconeybe dconeybe self-assigned this Dec 12, 2023
@dconeybe dconeybe changed the title Firestore: Increase allowed clock skew in FIRServerTimestampTests.mm Firestore: Increase clock skew tolerance in FIRServerTimestampTests.mm Dec 12, 2023
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.09% (97fb5c2) to 88.15% (30b21fd) by +0.06%.

    FilenameBase (97fb5c2)Merge (30b21fd)Diff
    exception.cc23.68%84.21%+60.53%
    leveldb_key.cc98.82%98.14%-0.69%
    ordered_code.cc93.90%94.39%+0.49%
    write_stream.cc94.37%91.55%-2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/n1mx79tZcM.html

@dconeybe dconeybe marked this pull request as ready for review December 13, 2023 00:51
@dconeybe dconeybe enabled auto-merge (squash) December 13, 2023 00:53
@dconeybe dconeybe merged commit 5fba1e7 into master Dec 13, 2023
50 checks passed
@dconeybe dconeybe deleted the dconeybe/TimestampSkewFix branch December 13, 2023 01:05
@firebase firebase locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants