Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[SwiftPM] Update 'firebaseVersion' to 10.19.1 (#12195)" #12198

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Revert "[SwiftPM] Update 'firebaseVersion' to 10.19.1 (#12195)" #12198

merged 1 commit into from
Dec 14, 2023

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Dec 14, 2023 •
edited by paulb777
Loading

This reverts commit c60c958.

Now that 10.19.1 is released, switch version back to 10.20

@ncooke3 ncooke3 requested a review from andrewheard December 14, 2023 16:56
andrewheard
andrewheard approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green. Thanks for handling the point release!

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

paulb777
paulb777 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after I fixed the description - 10.19 -> 10.19.1

@ncooke3 ncooke3 merged commit 9f8909a into master Dec 14, 2023
54 checks passed
@ncooke3 ncooke3 deleted the nc/spm-102000 branch December 14, 2023 17:39
@firebase firebase locked and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewheard andrewheard andrewheard approved these changes

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncooke3 @google-oss-bot @paulb777 @andrewheard