Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rollouts] Crashlytics Rollouts interop Integration #12200

Merged
merged 2 commits into from
Dec 20, 2023
Merged

[Rollouts] Crashlytics Rollouts interop Integration #12200

merged 2 commits into from
Dec 20, 2023

Conversation

themiswang
Copy link
Contributor

@themiswang themiswang commented Dec 14, 2023 •
edited
Loading

  • Adding interop dependency to Crashlytics SDK
  • Validate the rollouts data on Crash side(maxNumOfAssignments, maxLengthOfParamValue)
  • Adding support for Crashlytics writing swift code
  • Unit tests

#no-changelog

@themiswang themiswang marked this pull request as ready for review December 20, 2023 19:50
samedson
samedson approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@samedson samedson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a few suggestions, but otherwise this looks great!

@themiswang themiswang merged commit f0257a9 into featureRollouts Dec 20, 2023
70 of 72 checks passed
@themiswang themiswang deleted the crashIntegration branch December 20, 2023 21:06
themiswang added a commit that referenced this pull request Dec 20, 2023
@themiswang
[Rollouts] Crashlytics Rollouts interop Integration (#12200)
5b2e0e0
themiswang added a commit that referenced this pull request Jan 8, 2024
@themiswang
[Rollouts] Crashlytics Rollouts interop Integration (#12200)
32e65f4
@firebase firebase locked and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samedson samedson samedson approved these changes

@danasilver danasilver danasilver approved these changes

@ddnan ddnan Awaiting requested review from ddnan

Assignees
No one assigned
Labels
api: crashlytics api: rollouts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@themiswang @samedson @danasilver @google-oss-bot