Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable flaky messaging integration test #12206

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Disable flaky messaging integration test #12206

merged 2 commits into from
Dec 18, 2023

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Dec 15, 2023 •
edited
Loading

Workaround until #12205 is fixed

Fix #12197

@paulb777 paulb777 mentioned this pull request Dec 15, 2023
Open
@google-oss-bot
Copy link

Size Report 1

Affected Products

  • FirebaseMessaging

    TypeBase (ca522d2)Merge (3bb7e03)Diff
    CocoaPods-51.5 kB-51.5 kB-1 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/re60MMg3nm.html

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    Overall coverage changed from 60.43% (ca522d2) to 60.51% (3bb7e03) by +0.08%.

    FilenameBase (ca522d2)Merge (3bb7e03)Diff
    FIRMessagingCheckinPreferences.m93.07%98.02%+4.95%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GPo4kgeiHZ.html

@paulb777 paulb777 requested a review from ncooke3 December 15, 2023 22:26
@paulb777 paulb777 enabled auto-merge (squash) December 15, 2023 22:49
@paulb777 paulb777 merged commit 5890db9 into main Dec 18, 2023
101 checks passed
@paulb777 paulb777 deleted the pb-disable-flake branch December 18, 2023 21:30
@firebase firebase locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
api: messaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nightly Testing Report
3 participants
@paulb777 @google-oss-bot @ncooke3