Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage Integration Test flakiness #12235

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Storage Integration Test flakiness #12235

merged 1 commit into from
Jan 3, 2024

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Jan 3, 2024

Use unique names to try to address recent storage integration test flakiness

Also move task.cancel after task.observe to address another possible flake

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@paulb777 paulb777 enabled auto-merge (squash) January 3, 2024 20:51
@paulb777 paulb777 requested a review from andrewheard January 3, 2024 20:52
@paulb777 paulb777 merged commit 1104c72 into main Jan 3, 2024
55 checks passed
@paulb777 paulb777 deleted the pb-storage-int-test-flake branch January 3, 2024 20:54
@paulb777 paulb777 mentioned this pull request Jan 4, 2024
Closed
@firebase firebase locked and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewheard andrewheard andrewheard approved these changes

Assignees
No one assigned
Labels
api: storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @google-oss-bot @andrewheard