Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rollouts] Rollouts serialization #12258

Merged
merged 1 commit into from
Jan 10, 2024
Merged

[Rollouts] Rollouts serialization #12258

merged 1 commit into from
Jan 10, 2024

Conversation

themiswang
Copy link
Contributor

@themiswang themiswang commented Jan 10, 2024 •
edited
Loading

  • Adding a intermediate data object EncodedRolloutAssignment to process string value hex encoding and serialization
  • Re-write FIRCLSFileHexEncodeString logic to swift
  • Unit testing

Checked rollouts are successfully attached to non-fatals after integration:
Screenshot 2024-01-09 at 6 11 40 PM

#no-changelog

@themiswang themiswang force-pushed the rolloutsSerialization branch from cdb4f14 to 689a194 Compare January 10, 2024 13:53
@themiswang themiswang marked this pull request as ready for review January 10, 2024 13:54
@themiswang themiswang force-pushed the rolloutsSerialization branch from 689a194 to a8873d5 Compare January 10, 2024 15:26
danasilver
danasilver approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@danasilver danasilver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but probably should get a review from @samedson too

samedson
samedson approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@samedson samedson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had one bit of feedback around logging, but looks good!

@themiswang themiswang force-pushed the rolloutsSerialization branch from a8873d5 to 427d963 Compare January 10, 2024 22:50
@themiswang themiswang force-pushed the rolloutsSerialization branch from 427d963 to e927d37 Compare January 10, 2024 22:54
@themiswang themiswang merged commit 50b72c1 into featureRollouts Jan 10, 2024
89 of 92 checks passed
@themiswang themiswang deleted the rolloutsSerialization branch January 10, 2024 23:47
themiswang added a commit that referenced this pull request Jan 23, 2024
@themiswang
[Rollouts] Rollouts serialization (#12258)
c2d3a94
@firebase firebase locked and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danasilver danasilver danasilver approved these changes

@samedson samedson samedson approved these changes

Assignees
No one assigned
Labels
api: crashlytics api: remoteconfig api: rollouts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@themiswang @samedson @danasilver @google-oss-bot