Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Xcode 15.2 in CI workflows #12302

Merged
merged 8 commits into from
Jan 23, 2024
Merged

Update to Xcode 15.2 in CI workflows #12302

merged 8 commits into from
Jan 23, 2024

Conversation

andrewheard
Copy link
Contributor

#no-changelog

@andrewheard andrewheard changed the title Update to Xcode 15.2 in SPM workflow Update to Xcode 15.2 in CI workflows Jan 19, 2024
@google-oss-bot
Copy link

google-oss-bot commented Jan 20, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseDynamicLinks-iOS-FirebaseDynamicLinks.framework

    Overall coverage changed from 76.10% (d184db7) to 61.52% (7417b83) by -14.58%.

    FilenameBase (d184db7)Merge (7417b83)Diff
    FDLDeviceHeuristicsHelper.m100.00%0.00%-100.00%
    FDLUtilities.m89.68%75.40%-14.29%
    FIRDLDefaultRetrievalProcessV2.m73.10%14.04%-59.06%
    FIRDLJavaScriptExecutor.m82.95%24.81%-58.14%
    FIRDynamicLinkNetworking.m79.75%45.09%-34.66%

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.18% (d184db7) to 88.10% (7417b83) by -0.07%.

    FilenameBase (d184db7)Merge (7417b83)Diff
    exception.cc84.21%23.68%-60.53%
    leveldb_key.cc98.43%98.82%+0.39%

  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    Overall coverage changed from 60.08% (d184db7) to 60.16% (7417b83) by +0.08%.

    FilenameBase (d184db7)Merge (7417b83)Diff
    FIRMessagingCheckinPreferences.m93.07%98.02%+4.95%

  • FirebasePerformance-iOS-FirebasePerformance.framework

    Overall coverage changed from 94.71% (d184db7) to 94.76% (7417b83) by +0.05%.

    FilenameBase (d184db7)Merge (7417b83)Diff
    FPRGaugeManager.m95.42%97.39%+1.96%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/wgZm3WWk6w.html

paulb777
paulb777 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge after reverting the Storage change and then follow up via nightlies

FirebaseStorage/Tests/Integration/StorageIntegration.swift Outdated Show resolved Hide resolved
@andrewheard andrewheard marked this pull request as ready for review January 23, 2024 20:38
@paulb777
Copy link
Member

Got a green storage run https://github.com/firebase/firebase-ios-sdk/actions/runs/7630648505. I'll merge it here and we can follow up via nightlies.

@paulb777 paulb777 merged commit 5048195 into main Jan 23, 2024
480 checks passed
@paulb777 paulb777 deleted the ah/xcode-15.2 branch January 23, 2024 21:33
@firebase firebase locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewheard @google-oss-bot @paulb777