[Rollouts] Set active rollout metadata after activating config #12316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danasilver
approved these changes
Jan 25, 2024
| @@ -329,6 +329,8 @@ - (void)activateWithCompletion:(FIRRemoteConfigActivateChangeCompletion)completi | |||
| // New config has been activated at this point | |||
| FIRLogDebug(kFIRLoggerRemoteConfig, @"I-RCN000069", @"Config activated."); | |||
| [strongSelf->_configContent activatePersonalization]; | |||
| [strongSelf->_settings updateLastActiveTemplateVersion]; | |||
There was a problem hiding this comment.
Thinking: We don't need to wait for this to complete before calling activateRolloutMetadata since UserDefaults is updated synchronously in the process (and persisted to disk async) so rollouts will get the latest value in the process https://developer.apple.com/documentation/foundation/userdefaults#overview
There was a problem hiding this comment.
Make sense to me. Dispatch the activeTemplateVersion updating.
There was a problem hiding this comment.
Ah, I was saying I think that the previous code (synchronously) is fine, since UserDefaults is updated in the process synchronously. Can revisit this when we use the value in a subsequent PR, though
karenyz
reviewed
Jan 25, 2024
themiswang
pushed a commit
that referenced
this pull request
Feb 13, 2024
themiswang
pushed a commit
that referenced
this pull request
Feb 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set active rollout metadata after activate config.
Add last active template version to userDefault.
Looks like the previous PR is getting bigger, split this part into a PR for better review. Notifying interop logic will be in a following PR.
Note: this change will merge to our feature branch not master
#no-changelog