Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require at least CocoaPods version 1.12.0 #12322

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Require at least CocoaPods version 1.12.0 #12322

merged 2 commits into from
Jan 26, 2024

Conversation

paulb777
Copy link
Member

At least CocoaPods version 1.12.0 is required to support privacy manifests. This change will enforce the requirement at installation time.

More context at google/gtm-session-fetcher#375

@google-oss-bot
Copy link

google-oss-bot commented Jan 26, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.15% (26184fc) to 88.08% (5e02cf5) by -0.07%.

    FilenameBase (26184fc)Merge (5e02cf5)Diff
    leveldb_persistence.cc93.59%92.31%-1.28%
    leveldb_remote_document_cache.cc96.55%94.83%-1.72%
    lru_garbage_collector.cc96.06%91.34%-4.72%
    status.cc75.89%73.05%-2.84%
    write_stream.cc94.37%91.55%-2.82%

  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    Overall coverage changed from 60.03% (26184fc) to 60.11% (5e02cf5) by +0.08%.

    FilenameBase (26184fc)Merge (5e02cf5)Diff
    FIRMessagingCheckinPreferences.m93.07%98.02%+4.95%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jkLxncc3mf.html

ncooke3
ncooke3 approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! CI failures look like flakes to me.

@paulb777 paulb777 merged commit b7d6209 into main Jan 26, 2024
455 of 465 checks passed
@paulb777 paulb777 deleted the pb-cocoapods-min branch January 26, 2024 21:38
ncooke3 added a commit to firebase/SpecsStaging that referenced this pull request Jan 26, 2024
@ncooke3
Manually update specs to match firebase/firebase-ios-sdk#12322
6496f43 
git grep --name-only 'cocoapods_version' | xargs sed -i '' -E "s/cocoapods_version\": \">=.*/cocoapods_version\": \">= 1.12.0\",/"
@firebase firebase locked and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
api: analytics api: appcheck api: appdistribution api: auth api: core api: crashlytics api: database api: dynamiclinks api: firestore api: functions api: inappmessaging Firebase In App Messaging api: installations api: messaging api: performance api: remoteconfig api: storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @google-oss-bot @ncooke3