-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release Tooling] Only embed bundles containing privacy manifests #12324
Conversation
Generated by 🚫 Danger |
Zip built successfully locally. Verified that the three existing bundles are still packed in their own resources directory, with the GTM session fetcher directories being embedded:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the README with instructions about resources need to be updated?
No. Eventually, we will want to recommend zip users to embed frameworks so their apps include the privacy manifests. I'd like to better understand https://stackoverflow.com/questions/77888962/issue-trying-to-run-app-on-ios-simulator-missing-a-plist-from-firebase before adding those docs. Because if that issue is widespread, we may have to add plists back– which will cause issues when embedding and will require a different approach/docs. |
Xcode 14 friendly version of #12114.
The first commit was something I had stashed a few weeks back. Revisiting it now, I simplified it with the file enumerator approach.