Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove placeholder token constant from Firebase App Check #12374

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Remove placeholder token constant from Firebase App Check #12374

merged 1 commit into from
Feb 8, 2024

Conversation

andrewheard
Copy link
Contributor

The private kDummyFACTokenValue constant is no longer used in Firebase App Check. The replacement constant now lives in App Check Core: https://github.com/google/app-check/blob/3e464dad87dad2d29bb29a97836789bf0f8f67d2/AppCheckCore/Sources/Core/GACAppCheckTokenResult.m#L21-L23

#no-changelog

@andrewheard andrewheard requested a review from paulb777 February 7, 2024 23:27
paulb777
paulb777 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@andrewheard andrewheard merged commit cd1ee8d into main Feb 8, 2024
68 checks passed
@andrewheard andrewheard deleted the ah/appcheck-placeholder branch February 8, 2024 00:34
@firebase firebase locked and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: appcheck
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewheard @paulb777 @google-oss-bot