Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[auth-swift] Reimplement AuthTestingSupport in Swift #12377

Merged
merged 1 commit into from
Feb 9, 2024
Merged

[auth-swift] Reimplement AuthTestingSupport in Swift #12377

merged 1 commit into from
Feb 9, 2024

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Feb 9, 2024 •
edited
Loading

The Objective-C implementation of the fake did not work with the Swift implementation of Auth.

Migrates the implementation to Swift and run essentially the same unit tests run.

This is a prerequisite for restoring the Combine build.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@paulb777 paulb777 merged commit d049a9d into auth-swift Feb 9, 2024
55 checks passed
@paulb777 paulb777 deleted the pb-authtestingsupport branch February 9, 2024 23:24
@firebase firebase locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

@peterfriese peterfriese Awaiting requested review from peterfriese

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @google-oss-bot @ncooke3