Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rollouts] Feature rollouts merge to main #12410

Merged
merged 19 commits into from
Mar 11, 2024
Merged

[Rollouts] Feature rollouts merge to main #12410

merged 19 commits into from
Mar 11, 2024

Conversation

themiswang
Copy link
Contributor

@themiswang themiswang commented Feb 21, 2024 •
edited
Loading

Rollouts feature branch merge back to main.

lunchcal: launch/4286643

@google-oss-bot
Copy link

google-oss-bot commented Feb 21, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseRemoteConfig-iOS-FirebaseRemoteConfig.framework

    Overall coverage changed from 72.24% (34667bc) to 72.98% (ae1b454) by +0.74%.

    FilenameBase (34667bc)Merge (ae1b454)Diff
    FIRRemoteConfig.m83.91%82.63%-1.28%
    FIRRemoteConfigComponent.m97.06%93.07%-3.99%
    RCNConfigContent.m81.90%84.83%+2.93%
    RCNConfigDBManager.m76.43%77.08%+0.65%
    RCNConfigSettings.m62.81%63.41%+0.60%
    RCNUserDefaultsManager.m98.43%98.52%+0.09%

  • FirebaseRemoteConfig-iOS-FirebaseRemoteConfigInterop.framework

    Overall coverage changed from ? (34667bc) to 100.00% (ae1b454) by ?.

    FilenameBase (34667bc)Merge (ae1b454)Diff
    RolloutAssignment.swift?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mJtHPyPG15.html

themiswang
themiswang commented Feb 21, 2024
View reviewed changes
ClientApp/Podfile Outdated Show resolved Hide resolved
@themiswang themiswang mentioned this pull request Feb 21, 2024
Merged
@paulb777
Copy link
Member

The new interop pod should be added to https://github.com/firebase/firebase-ios-sdk/blob/main/ReleaseTooling/Sources/FirebaseManifest/FirebaseManifest.swift

@themiswang
Copy link
Contributor Author

themiswang commented Feb 21, 2024 •
edited
Loading

The new interop pod should be added to https://github.com/firebase/firebase-ios-sdk/blob/main/ReleaseTooling/Sources/FirebaseManifest/FirebaseManifest.swift

Thank you for the reference! I will ask for another review prior to the release for M145

@themiswang themiswang marked this pull request as ready for review March 4, 2024 21:13
@themiswang themiswang force-pushed the featureRollouts branch 2 times, most recently from 0dfaac6 to 47ed633 Compare March 8, 2024 19:22
@themiswang
Copy link
Contributor Author

Hey @paulb777, our launchcal all bits are flipped. We are ready for merging back to main. There is 2 unit tests failed related to release tool and the related change is here: #12464. Let me know if there is anything need to do on my side and we are ready to go!

@themiswang themiswang requested a review from paulb777 March 8, 2024 20:46
paulb777
paulb777 reviewed Mar 8, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through all the details on this @themiswang.

I have a few nits/questions and then LGTM

We can stage FirebaseRemoteConfigInterop after merge and that should address the zip builder ci failures.

FirebaseRemoteConfigSwift/Tests/SwiftAPI/FirebaseRemoteConfigSwift_APIBuildTests.swift Outdated Show resolved Hide resolved
Crashlytics/CHANGELOG.md Outdated Show resolved Hide resolved
FirebaseRemoteConfig/CHANGELOG.md Show resolved Hide resolved
FirebaseRemoteConfig/Sources/RCNConfigDBManager.h Outdated Show resolved Hide resolved
ddnan and others added 14 commits March 11, 2024 14:50
@ddnan @themiswang
[Rollouts] Implement insert and load logic for rollout metadata in RC (…
96e2e99 
…#12262)
@themiswang
[Rollouts]Writing Rollouts to persistence (#12300)
b9b970d
@ddnan @themiswang
[Rollouts] Set active rollout metadata after activating config (#12316)
3d9a9a7
@ddnan @themiswang
[Rollouts] Diff rollout metadata for updatedKeys in RemoteConfigUpdat…
d974256 
…er (#12333)
@ddnan @themiswang
[Rollouts]Add remote config logic to featureRollouts test app (#12349)
09d4d56
@ddnan @themiswang
[Rollouts] Notify RolloutsState change to Interop subscriber (#12334)
5cfc356
@themiswang
[Rollouts] Address feature branch comments (#12411)
6030c01
@ddnan @themiswang
Add Fireperf dependency to feature rollouts test app (#12430)
5fa7507
@themiswang
add release notes and privacy manifest for interop (#12464)
4ffcaef
@themiswang
fix unit test (#12499)
c528a52
@themiswang
Fix rollouts tests (#12500)
5dabfd5
@themiswang
reword parameter name (#12502)
37fce03
@themiswang
edit release notes (#12515)
1e3b0e8
@ddnan @themiswang
[Rollouts] Revert constants change in remote config public api test (#…
98ecf0e 
…12503)
@themiswang themiswang merged commit 90c33e4 into main Mar 11, 2024
158 of 160 checks passed
@themiswang themiswang deleted the featureRollouts branch March 11, 2024 20:13
@themiswang themiswang mentioned this pull request Mar 25, 2024
Closed
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager Apr 9, 2024
@cgrindel-self-hosted-renovate
chore(deps): update dependency firebase/firebase-ios-sdk to from: "10…
8cead7d 
….23.1" (#948)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[firebase/firebase-ios-sdk](https://togithub.com/firebase/firebase-ios-sdk)
| minor | `from: "10.21.0"` -> `from: "10.23.1"` |

---

### Release Notes

<details>
<summary>firebase/firebase-ios-sdk (firebase/firebase-ios-sdk)</summary>

###
[`v10.23.1`](https://togithub.com/firebase/firebase-ios-sdk/releases/tag/10.23.1)

[Compare
Source](https://togithub.com/firebase/firebase-ios-sdk/compare/10.23.0...10.23.1)

The Firebase Apple SDK (10.23.1) is now available.

This release is only available for CocoaPods and Swift Package Manager
and only changes Firebase Analytics.

See details at [Firebase Apple SDK release
notes.](https://firebase.google.com/support/release-notes/ios#10.23.1)

#### What's Changed

- \[Release] Update Package.swift for 10.23.1 patch by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12644](https://togithub.com/firebase/firebase-ios-sdk/pull/12644)
- Analytics 10.23.1 by [@&#8203;htcgh](https://togithub.com/htcgh) in
[https://github.com/firebase/firebase-ios-sdk/pull/12648](https://togithub.com/firebase/firebase-ios-sdk/pull/12648)
- 10.23.1 podspec updates by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12647](https://togithub.com/firebase/firebase-ios-sdk/pull/12647)
- Tweak release note by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12649](https://togithub.com/firebase/firebase-ios-sdk/pull/12649)

**Full Changelog**:
firebase/firebase-ios-sdk@10.23.0...10.23.1

###
[`v10.23.0`](https://togithub.com/firebase/firebase-ios-sdk/releases/tag/10.23.0)

[Compare
Source](https://togithub.com/firebase/firebase-ios-sdk/compare/10.22.1...10.23.0)

The Firebase Apple SDK (10.23.0) is now available. For more details, see
the [Firebase Apple SDK release
notes.](https://firebase.google.com/support/release-notes/ios#10.23.0)

To install this SDK, see [Add Firebase to your
project.](https://firebase.google.com/docs/ios/setup)

#### What's Changed

- \[Release] Update versions for Release 10.23.0 by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/12467](https://togithub.com/firebase/firebase-ios-sdk/pull/12467)
- Add API tests for hashed email and phone number by
[@&#8203;tsunghung](https://togithub.com/tsunghung) in
[https://github.com/firebase/firebase-ios-sdk/pull/12469](https://togithub.com/firebase/firebase-ios-sdk/pull/12469)
- Update upload-symbols to 13.7 by
[@&#8203;themiswang](https://togithub.com/themiswang) in
[https://github.com/firebase/firebase-ios-sdk/pull/12471](https://togithub.com/firebase/firebase-ios-sdk/pull/12471)
- Analytics 10.22.1 by
[@&#8203;tsunghung](https://togithub.com/tsunghung) in
[https://github.com/firebase/firebase-ios-sdk/pull/12482](https://togithub.com/firebase/firebase-ios-sdk/pull/12482)
- Upgrade `clang-format` to v18 by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/12483](https://togithub.com/firebase/firebase-ios-sdk/pull/12483)
- \[Release] Add patch note for 10.22.1 by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12490](https://togithub.com/firebase/firebase-ios-sdk/pull/12490)
- Restore 10.23.0 versions to main after 10.22.1 by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12497](https://togithub.com/firebase/firebase-ios-sdk/pull/12497)
- Patch abseil-cpp to ignore deprecated errors in new Xcode. by
[@&#8203;jonsimantov](https://togithub.com/jonsimantov) in
[https://github.com/firebase/firebase-ios-sdk/pull/12498](https://togithub.com/firebase/firebase-ios-sdk/pull/12498)
- Fix CI breakage from recent merge by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12504](https://togithub.com/firebase/firebase-ios-sdk/pull/12504)
- Resolved warning no rule to process file 'PrivacyInfo.xcprivacy' of
type 'text.xml' with CocoaPods by
[@&#8203;HikaruSato](https://togithub.com/HikaruSato) in
[https://github.com/firebase/firebase-ios-sdk/pull/12513](https://togithub.com/firebase/firebase-ios-sdk/pull/12513)
- Upgrade grpc to 1.62 for cocoapods by
[@&#8203;wu-hui](https://togithub.com/wu-hui) in
[https://github.com/firebase/firebase-ios-sdk/pull/12398](https://togithub.com/firebase/firebase-ios-sdk/pull/12398)
- Snapshot listener source from cache by
[@&#8203;milaGGL](https://togithub.com/milaGGL) in
[https://github.com/firebase/firebase-ios-sdk/pull/12370](https://togithub.com/firebase/firebase-ios-sdk/pull/12370)
- \[Rollouts] Feature rollouts merge to main by
[@&#8203;themiswang](https://togithub.com/themiswang) in
[https://github.com/firebase/firebase-ios-sdk/pull/12410](https://togithub.com/firebase/firebase-ios-sdk/pull/12410)
- \[spm] Update grpc to 1.62.3 by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12520](https://togithub.com/firebase/firebase-ios-sdk/pull/12520)
- \[Release Tooling] Copy over macOS/macCatalyst plists by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12517](https://togithub.com/firebase/firebase-ios-sdk/pull/12517)
- NOTICES Change by
[@&#8203;github-actions](https://togithub.com/github-actions) in
[https://github.com/firebase/firebase-ios-sdk/pull/12524](https://togithub.com/firebase/firebase-ios-sdk/pull/12524)
- Changelog updates for 10.23.0 by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12533](https://togithub.com/firebase/firebase-ios-sdk/pull/12533)
- \[Firestore] Improve logging in scripts/check_firestore_symbols.sh by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12535](https://togithub.com/firebase/firebase-ios-sdk/pull/12535)
- \[Firestore] Add unlinked symbol introduced in
[#&#8203;12370](https://togithub.com/firebase/firebase-ios-sdk/issues/12370)
by [@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12534](https://togithub.com/firebase/firebase-ios-sdk/pull/12534)
- \[Firestore] Re-export public header added in
[#&#8203;12370](https://togithub.com/firebase/firebase-ios-sdk/issues/12370)
by [@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12537](https://togithub.com/firebase/firebase-ios-sdk/pull/12537)
- \[Firestore] Bump dependency ranges for Firestore's binary SPM distro
by [@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12538](https://togithub.com/firebase/firebase-ios-sdk/pull/12538)
- Fix Firestore build warnings by
[@&#8203;cherylEnkidu](https://togithub.com/cherylEnkidu) in
[https://github.com/firebase/firebase-ios-sdk/pull/12536](https://togithub.com/firebase/firebase-ios-sdk/pull/12536)
- Analytics 10.23.0 by [@&#8203;htcgh](https://togithub.com/htcgh) in
[https://github.com/firebase/firebase-ios-sdk/pull/12539](https://togithub.com/firebase/firebase-ios-sdk/pull/12539)
- \[Release] Update FirebaseFirestoreInternal checksum by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12545](https://togithub.com/firebase/firebase-ios-sdk/pull/12545)
- \[Release] Re-spin FST with signed artifact by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12549](https://togithub.com/firebase/firebase-ios-sdk/pull/12549)

#### New Contributors

- [@&#8203;HikaruSato](https://togithub.com/HikaruSato) made their first
contribution in
[https://github.com/firebase/firebase-ios-sdk/pull/12513](https://togithub.com/firebase/firebase-ios-sdk/pull/12513)

**Full Changelog**:
firebase/firebase-ios-sdk@10.22.1...10.23.0

###
[`v10.22.1`](https://togithub.com/firebase/firebase-ios-sdk/releases/tag/10.22.1):
Firebase Apple 10.22.1

[Compare
Source](https://togithub.com/firebase/firebase-ios-sdk/compare/10.22.0...10.22.1)

The Firebase Apple SDK (10.22.1) is now available. For more details, see
the [Firebase Apple SDK release
notes.](https://firebase.google.com/support/release-notes/ios#10.22.1)

To install this SDK, see [Add Firebase to your
project.](https://firebase.google.com/docs/ios/setup)

###
[`v10.22.0`](https://togithub.com/firebase/firebase-ios-sdk/releases/tag/10.22.0):
Firebase Apple 10.22.0

[Compare
Source](https://togithub.com/firebase/firebase-ios-sdk/compare/10.21.0...10.22.0)

The Firebase Apple SDK (10.22.0) is now available. For more details, see
the [Firebase Apple SDK release
notes](https://firebase.google.com/support/release-notes/ios#10.22.0).

To install this SDK, see [Add Firebase to your
project](https://firebase.google.com/docs/ios/setup).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
@firebase firebase locked and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ddnan ddnan ddnan left review comments

@danasilver danasilver danasilver approved these changes

@samedson samedson samedson approved these changes

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: core api: crashlytics api: remoteconfig api: rollouts release-tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@themiswang @google-oss-bot @paulb777 @samedson @danasilver @ddnan