Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API tests for hashed email and phone number #12469

Merged
merged 1 commit into from
Mar 5, 2024
+4 −0
Merged

Add API tests for hashed email and phone number #12469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions FirebaseAnalyticsSwift/Tests/ObjCAPI/ObjCAPITests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ - (void)consentTests:(NSURL *)url {
- (void)onDeviceConversionTests:(NSURL *)url {
[FIRAnalytics initiateOnDeviceConversionMeasurementWithEmailAddress:@"[email protected]"];
[FIRAnalytics initiateOnDeviceConversionMeasurementWithPhoneNumber:@"+15555555555"];
[FIRAnalytics initiateOnDeviceConversionMeasurementWithHashedEmailAddress:[NSData data]];
[FIRAnalytics initiateOnDeviceConversionMeasurementWithHashedPhoneNumber:[NSData data]];
}

- (NSArray<NSString *> *)eventNames {
Expand Down
2 changes: 2 additions & 0 deletions FirebaseAnalyticsSwift/Tests/SwiftUnit/AnalyticsAPITests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ final class AnalyticsAPITests {

Analytics.initiateOnDeviceConversionMeasurement(emailAddress: "[email protected]")
Analytics.initiateOnDeviceConversionMeasurement(phoneNumber: "+15555555555")
Analytics.initiateOnDeviceConversionMeasurement(hashedEmailAddress: Data())
Analytics.initiateOnDeviceConversionMeasurement(hashedPhoneNumber: Data())

// MARK: - EventNames

Expand Down
Loading