Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use forked google-generative-ai in Vertex AI samples #12574

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

andrewheard
Copy link
Contributor

  • Removed the SPM dependency on generative-ai-swift
  • Updated VertexAI / VertexAIComponent to use forked classes
  • Updated GenerativeModel classes to call Vertex AI instead of Google AI
  • Updated samples to reflect SDK changes

#no-changelog

@andrewheard andrewheard marked this pull request as ready for review March 18, 2024 19:45
@andrewheard andrewheard requested a review from paulb777 March 18, 2024 19:45
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get CI infra in place in an upcoming PR

urlRequest.setValue("genai-swift/\(GenerativeAISwift.version)",
forHTTPHeaderField: "x-goog-api-client")
// TODO: Determine the right client header to use.
// urlRequest.setValue("genai-swift/\(GenerativeAISwift.version))",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FirebaseVersion() ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think FirebaseVersion() will be what we want instead of GenerativeAISwift.version but the prefix genai-swift will need to change too. Will leave it all commented out until that part is figured out.

@andrewheard andrewheard merged commit 3ef7816 into vertex-ai Mar 18, 2024
49 checks passed
@andrewheard andrewheard deleted the ah/vertex-ai branch March 18, 2024 21:16
@firebase firebase locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants