Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample app for passkey #12658

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Sample app for passkey #12658

merged 3 commits into from
Apr 9, 2024

Conversation

Xiaoshouzi-gh
Copy link
Contributor

@Xiaoshouzi-gh Xiaoshouzi-gh commented Mar 28, 2024

Added a passkey section in sample app for sign up with passkey, enrollment with passkey, sign in with passkey and withdraw passkey workflows.

This PR addressed the comments in #12128.
This PR added passkey withdraw workflow in sample app

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@Xiaoshouzi-gh Xiaoshouzi-gh requested a review from renkelvin March 29, 2024 17:07
@Xiaoshouzi-gh Xiaoshouzi-gh marked this pull request as ready for review April 2, 2024 18:17
for (FIRPasskeyInfo *info in _user.enrolledPasskeys) {
[string appendString:info.name];
[string appendString:@" - "];
[string appendString:info.credentialID];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add separators between the passkey strings?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a space following MFA

FirebaseAuth/Tests/Sample/Sample/MainViewController.m Outdated Show resolved Hide resolved
@Xiaoshouzi-gh Xiaoshouzi-gh merged commit d51c75b into passkey Apr 9, 2024
70 checks passed
@Xiaoshouzi-gh Xiaoshouzi-gh deleted the passkey-sample-main branch April 9, 2024 15:16
@firebase firebase locked and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants