[Release Tooling] Fix METADATA.md regression introduced in #12595 #12661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncooke3
commented
Mar 29, 2024
|
Merging what I had as it is a partial fix. |
|
Upon closer inspection, it looks like the latest GSI release is bundling the previous resources with the privacy manifest (https://github.com/google/GoogleSignIn-iOS/blob/a7965d134c5d3567026c523e0a8a583f73b62b0d/GoogleSignIn.podspec#L40C47-L40C56). This has the side effect of our release tooling seeing the privacy manifest and placing the bundle in the framework. So, this PR is sufficient. |
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Apr 9, 2024
….24.0" (#1007) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [firebase/firebase-ios-sdk](https://togithub.com/firebase/firebase-ios-sdk) | minor | `from: "10.23.1"` -> `from: "10.24.0"` | --- ### Release Notes <details> <summary>firebase/firebase-ios-sdk (firebase/firebase-ios-sdk)</summary> ### [`v10.24.0`](https://togithub.com/firebase/firebase-ios-sdk/releases/tag/10.24.0): Firebase Apple 10.24.0 [Compare Source](https://togithub.com/firebase/firebase-ios-sdk/compare/10.23.1...10.24.0) The Firebase Apple SDK (10.24.0) is now available. For more details, see the [Firebase Apple SDK release notes.](https://firebase.google.com/support/release-notes/ios#10.24.0) To install this SDK, see [Add Firebase to your project.](https://firebase.google.com/docs/ios/setup) #### What's Changed - Remove calls to fstat in crashlytics by [@​volantwish](https://togithub.com/volantwish) in [https://github.com/firebase/firebase-ios-sdk/pull/12531](https://togithub.com/firebase/firebase-ios-sdk/pull/12531) - fix unit tests by [@​themiswang](https://togithub.com/themiswang) in [https://github.com/firebase/firebase-ios-sdk/pull/12553](https://togithub.com/firebase/firebase-ios-sdk/pull/12553) - \[Release] Add release note for signed artifact changes by [@​ncooke3](https://togithub.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12558](https://togithub.com/firebase/firebase-ios-sdk/pull/12558) - Fix typo by [@​paulb777](https://togithub.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12565](https://togithub.com/firebase/firebase-ios-sdk/pull/12565) - \[Firestore] Add a check to ensure FirestoreInternal has same public headers as Firestore by [@​ncooke3](https://togithub.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12575](https://togithub.com/firebase/firebase-ios-sdk/pull/12575) - Carthage 10.23.0 by [@​paulb777](https://togithub.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12588](https://togithub.com/firebase/firebase-ios-sdk/pull/12588) - Initial CI for visionOS by [@​paulb777](https://togithub.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12578](https://togithub.com/firebase/firebase-ios-sdk/pull/12578) - Upgrade cmake build to grpc 162 by [@​wu-hui](https://togithub.com/wu-hui) in [https://github.com/firebase/firebase-ios-sdk/pull/12417](https://togithub.com/firebase/firebase-ios-sdk/pull/12417) - More visionOS CI by [@​paulb777](https://togithub.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12608](https://togithub.com/firebase/firebase-ios-sdk/pull/12608) - Update versions for Release 10.24.0 by [@​paulb777](https://togithub.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12594](https://togithub.com/firebase/firebase-ios-sdk/pull/12594) - \[Release Tooling] Update XCFramework structure by [@​ncooke3](https://togithub.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12595](https://togithub.com/firebase/firebase-ios-sdk/pull/12595) - \[Docs] Update `FirebaseCore/CHANGELOG.md` with correct issue # by [@​ncooke3](https://togithub.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12639](https://togithub.com/firebase/firebase-ios-sdk/pull/12639) - Adds putFileHandle and putFileHandleAsync by [@​mattcomi](https://togithub.com/mattcomi) in [https://github.com/firebase/firebase-ios-sdk/pull/12580](https://togithub.com/firebase/firebase-ios-sdk/pull/12580) - \[CocoaPods] Lock FirestoreInternal version to Firestore by [@​paulb777](https://togithub.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12654](https://togithub.com/firebase/firebase-ios-sdk/pull/12654) - Merge 10.23.1 by [@​paulb777](https://togithub.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12655](https://togithub.com/firebase/firebase-ios-sdk/pull/12655) - \[Crashlytics] Fix missing Swift header error by [@​ncooke3](https://togithub.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12659](https://togithub.com/firebase/firebase-ios-sdk/pull/12659) - Move MIEQ to composite index tests by [@​milaGGL](https://togithub.com/milaGGL) in [https://github.com/firebase/firebase-ios-sdk/pull/12416](https://togithub.com/firebase/firebase-ios-sdk/pull/12416) - feat: add basic support to build frameworks and zip them for the Apple Watch by [@​jasesuperhero](https://togithub.com/jasesuperhero) in [https://github.com/firebase/firebase-ios-sdk/pull/12624](https://togithub.com/firebase/firebase-ios-sdk/pull/12624) - Release note for watchOS zip/Carthage by [@​paulb777](https://togithub.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12670](https://togithub.com/firebase/firebase-ios-sdk/pull/12670) - \[Crashlytics] Remove mach_absolute_time usages by [@​paulb777](https://togithub.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12664](https://togithub.com/firebase/firebase-ios-sdk/pull/12664) - Update to SwiftFormat 0.53.5 by [@​paulb777](https://togithub.com/paulb777) in [https://github.com/firebase/firebase-ios-sdk/pull/12665](https://togithub.com/firebase/firebase-ios-sdk/pull/12665) - Fix typo: Timout -> Timeout by [@​Jager-yoo](https://togithub.com/Jager-yoo) in [https://github.com/firebase/firebase-ios-sdk/pull/12672](https://togithub.com/firebase/firebase-ios-sdk/pull/12672) - \[Crashlytics] Regenerate privacy manifest by [@​ncooke3](https://togithub.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12675](https://togithub.com/firebase/firebase-ios-sdk/pull/12675) - \[Release] Version changelog entries for 10.24.0 by [@​ncooke3](https://togithub.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12677](https://togithub.com/firebase/firebase-ios-sdk/pull/12677) - \[Release Tooling] Fix METADATA.md regression introduced in [#​12595](https://togithub.com/firebase/firebase-ios-sdk/issues/12595) by [@​ncooke3](https://togithub.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12661](https://togithub.com/firebase/firebase-ios-sdk/pull/12661) - Analytics 10.24.0 by [@​tsunghung](https://togithub.com/tsunghung) in [https://github.com/firebase/firebase-ios-sdk/pull/12693](https://togithub.com/firebase/firebase-ios-sdk/pull/12693) - \[Release] Update binary SPM Firestore distro for 10.24.0 by [@​ncooke3](https://togithub.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12708](https://togithub.com/firebase/firebase-ios-sdk/pull/12708) - \[Release] Update Firestore's binary deps in Package.swift by [@​ncooke3](https://togithub.com/ncooke3) in [https://github.com/firebase/firebase-ios-sdk/pull/12709](https://togithub.com/firebase/firebase-ios-sdk/pull/12709) #### New Contributors - [@​volantwish](https://togithub.com/volantwish) made their first contribution in [https://github.com/firebase/firebase-ios-sdk/pull/12531](https://togithub.com/firebase/firebase-ios-sdk/pull/12531) - [@​mattcomi](https://togithub.com/mattcomi) made their first contribution in [https://github.com/firebase/firebase-ios-sdk/pull/12580](https://togithub.com/firebase/firebase-ios-sdk/pull/12580) - [@​jasesuperhero](https://togithub.com/jasesuperhero) made their first contribution in [https://github.com/firebase/firebase-ios-sdk/pull/12624](https://togithub.com/firebase/firebase-ios-sdk/pull/12624) - [@​Jager-yoo](https://togithub.com/Jager-yoo) made their first contribution in [https://github.com/firebase/firebase-ios-sdk/pull/12672](https://togithub.com/firebase/firebase-ios-sdk/pull/12672) **Full Changelog**: firebase/firebase-ios-sdk@10.23.1...10.24.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#no-changelog
When the tooling looks for resources, it was doing a recursive search and finding the
Resourcesdirectories in all of the macOS/macCatalyst directories (introduced in #12595). Since #12595, every macOS/macCatalyst framework has aResourcesdirectory to contain the framework-level Info.plist (this plist lives at the root of the .framework for other platforms). See below:From Apple Developer - Placing content in a bundle
So, to fix
METADATA.mdsaying that everything product has resources, do a shallow search in each product directory at the root of theFirebase.zip. The resultingMETADATA.mdshould match the 10.23.0METADATA.md.