Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertex AI preview versioning #12691

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Vertex AI preview versioning #12691

merged 3 commits into from
Apr 4, 2024

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Apr 3, 2024 •
edited
Loading

Based on https://semver.org/#spec-item-9

  • Start with 0.1.0-vertexai-preview
  • Fix some implementations and tests to handle both one and two digit major versions
  • Update tests to handle string suffix

Confirmed that SPM Update to Latest will do an automatic update from https://github.com/paulb777/app-check/releases/tag/0.1.0-vertexai-preview to https://github.com/paulb777/app-check/releases/tag/0.2.0-vertexai-preview

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@paulb777 paulb777 requested a review from andrewheard April 3, 2024 23:43
andrewheard
andrewheard approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out, Paul!

@paulb777 paulb777 merged commit 7b85605 into vertex-ai Apr 4, 2024
85 checks passed
@paulb777 paulb777 deleted the pb-vertexai-preview-versioning branch April 4, 2024 14:59
@andrewheard
Copy link
Contributor

cc: @ryanwilson

andrewheard pushed a commit that referenced this pull request May 1, 2024
@paulb777 @andrewheard
Vertex AI preview versioning (#12691)
7bf61d1
@firebase firebase locked and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewheard andrewheard andrewheard approved these changes

Assignees
No one assigned
Labels
api: core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @google-oss-bot @andrewheard