Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove apiVersion from RequestOptions in Vertex AI #12707

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Remove apiVersion from RequestOptions in Vertex AI #12707

merged 1 commit into from
Apr 4, 2024

Conversation

andrewheard
Copy link
Contributor

  • Removed the apiVersion parameter from the RequestOptions constructor in Vertex AI
  • Hardcoded v2beta since it is the only supported API version

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

paulb777
paulb777 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@andrewheard andrewheard merged commit 468013c into vertex-ai Apr 4, 2024
42 checks passed
@andrewheard andrewheard deleted the ah/vertex-ai-api-version branch April 4, 2024 19:15
andrewheard added a commit that referenced this pull request May 1, 2024
@andrewheard
Remove apiVersion from RequestOptions in Vertex AI (#12707)
e5637c1
@firebase firebase locked and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewheard @google-oss-bot @paulb777