Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder GoogleService-Info.plist to Vertex AI sample #12724

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Apr 8, 2024

  • Added a placeholder/fake GoogleService-Info.plist file to Vertex AI sample app to make it easier to see where to place a real one.
  • Added a projectID check for mockproject-1234, printing instructions to the console if the placeholder file has not been replaced.
  • Updated the sample's bundle ID to com.google.firebase.VertexAISample.
  • Added a README for the sample directory.

#no-changelog

@andrewheard andrewheard requested a review from ncooke3 April 8, 2024 21:30
Comment on lines +23 to +29
if let firebaseApp = FirebaseApp.app(), firebaseApp.options.projectID == "mockproject-1234" {
guard let bundleID = Bundle.main.bundleIdentifier else { fatalError() }
fatalError("You must create and/or download a valid `GoogleService-Info.plist` file for"
+ " \(bundleID) from https://console.firebase.google.com to run this sample. Replace the"
+ " existing `GoogleService-Info.plist` file in the `FirebaseVertexAI/Sample` directory"
+ " with this new file.")
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea!

@andrewheard andrewheard merged commit df34f3b into vertex-ai Apr 8, 2024
42 checks passed
@andrewheard andrewheard deleted the ah/vertex-ai-sample branch April 8, 2024 21:36
@firebase firebase locked and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants