Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Make Timestamp Sendable #14083

Merged
merged 3 commits into from
Nov 12, 2024
Merged

[Core] Make Timestamp Sendable #14083

merged 3 commits into from
Nov 12, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Nov 11, 2024

Timestamp is an immutable class with no mutable state.

#no-changelog

Copy link
Contributor

github-actions bot commented Nov 11, 2024

Apple API Diff Report

Commit: 3ec7549
Last updated: Mon Nov 11 15:12 PST 2024
View workflow logs & download artifacts


FirebaseCore

Classes

[MODIFIED] FIRTimestamp
[MODIFIED] FIRTimestamp
Swift:
+  class Timestamp : NSObject , NSCopying , @unchecked Sendable
-  class Timestamp : NSObject , NSCopying
-    init ( seconds : Int64 , nanoseconds : Int32 )
-    convenience init ( date : Date )
-    convenience init ()
-    func dateValue () -> Date
-    func compare ( _ other : Timestamp ) -> ComparisonResult
-    var seconds : Int64 { get }
-    var nanoseconds : Int32 { get }
Objective-C:
+  @interface FIRTimestamp : NSObject < NSCopying >
-  @interface FIRTimestamp : NSObject < NSCopying >
-    - ( nonnull instancetype ) initWithSeconds :( int64_t ) seconds nanoseconds :( int32_t ) nanoseconds ;
-    + ( nonnull instancetype ) timestampWithSeconds :( int64_t ) seconds nanoseconds :( int32_t ) nanoseconds ;
-    + ( nonnull instancetype ) timestampWithDate :( nonnull NSDate * ) date ;
-    + ( nonnull instancetype ) timestamp ;
-    - ( nonnull NSDate * ) dateValue ;
-    - ( NSComparisonResult ) compare :( nonnull FIRTimestamp * ) other ;
-    @property ( nonatomic , readonly ) int64_t seconds ;
-    @property ( nonatomic , readonly ) int32_t nanoseconds ;

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you force trigger Firestore CI to run.

LGTM on green after that.

@ncooke3 ncooke3 merged commit 7bdf3bb into main Nov 12, 2024
43 checks passed
@ncooke3 ncooke3 deleted the nc/sendable-timestamp branch November 12, 2024 18:16
@firebase firebase locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants