Skip to content

Conversation

@daymxn
Copy link
Member

@daymxn daymxn commented Oct 10, 2025

This PR adds unit tests for the Live API decoding/encoding. Since a lot of the API surface is covered by implicit Encodable (or alternatives) markers, this PR only really addresses the structs that have custom decoding or encoding logic.

Namely, this means VoiceConfig and BidiGenerateContentServerMessage both have had unit tests added. This basically just ensures they encode/decode correctly.

#no-changelog

@daymxn daymxn self-assigned this Oct 10, 2025
@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@daymxn daymxn requested review from andrewheard and ncooke3 October 16, 2025 19:14
@daymxn daymxn requested a review from andrewheard October 16, 2025 19:18
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds valuable unit tests for the Live API's encoding and decoding logic, focusing on VoiceConfig and BidiGenerateContentServerMessage. The tests are well-structured and cover the primary use cases effectively. I've added one minor suggestion to enhance the test coverage for BidiGenerateContentServerMessage by testing a minimal payload to ensure optional fields are handled correctly. Overall, this is a solid contribution to the project's test suite.

@daymxn daymxn merged commit 0e5a4e0 into main Oct 17, 2025
65 checks passed
@daymxn daymxn deleted the dlr/add-live-unit-tests branch October 17, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants